[SDK-248] notification-component#814

Open

lposen wants to merge 8 commits intoloren/embedded/SDK-367-parse-media-for-componentsfrom

loren/embedded/SDK-248-notification-component

Contributor

lposen commented Feb 12, 2026 •

edited

Loading

🔹 JIRA Ticket(s) if any

SDK-248

✏️ Description

Create notification component

Testing

Run example app
Click on embedded tab
Select "notification" as the view type
Click "get messages for placement ids" -- the messages should show as notifications
Click on the buttons -- they should do whatever they were configured to do when you set the embedded message
Click "set view config" and try overriding the styles. EG: set {"backgroundColor":"blue"}
- The style should update with your overrides

Screen.Recording.2026-02-23.at.6.21.55.PM.mov

lposen added 5 commits

February 12, 2026 14:10


          feat: add IterableEmbeddedNotification component for displaying notif…

95e8d92

…ications


          feat: add utility functions and styles for embedded views

ef7cf1d


          feat: implement useEmbeddedView hook for managing embedded view lifec…

980123d

…ycle


          feat: enhance IterableEmbeddedNotification with styles and button fun…

917835b

…ctionality


          feat: add hooks for managing embedded view styles and media

4a47ef2

github-actions bot commented Feb 12, 2026 •

edited

Loading

Lines	Statements	Branches	Functions
	63.89% (446/698)	48.7% (150/308)	59.67% (148/248)

qltysh bot commented Feb 12, 2026 •

edited

Loading

Coverage Impact

⬇️ Merging this pull request will decrease total coverage on loren/embedded/SDK-367-parse-media-for-components by 0.49%.

Modified Files with Diff Coverage (4)

Rating	File	% Diff	Uncovered Line #s
	src/embedded/hooks/useEmbeddedView/useEmbeddedView.ts	0.0%	51-61
	src/embedded/components/IterableEmbeddedView.tsx	100.0%
	...bleEmbeddedNotification/IterableEmbeddedNotification.styles.ts	100.0%
	.../IterableEmbeddedNotification/IterableEmbeddedNotification.tsx	100.0%
	Total	64.7%

🤖 Increase coverage with AI coding...

In the `loren/embedded/SDK-248-notification-component` branch, add test coverage for this new code:

- `src/embedded/hooks/useEmbeddedView/useEmbeddedView.ts` -- Line 51-61

🚦 See full report on Qlty Cloud »

🛟 Help

Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.
Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.
File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)
- Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

qltysh bot commented Feb 12, 2026 •

edited

Loading

❌ 10 blocking issues (14 total)

Tool	Category	Rule	Count
eslint	Lint	tsdoc-escape-right-brace: The "}" character should be escaped using a backslash to avoid confusion with a TSDoc inline tag	10	❌
qlty	Structure	Function with high complexity (count = 7): IterableEmbeddedNotification	2
qlty	Structure	Function with many returns (count = 5): IterableEmbeddedView	1
qlty	Structure	Function with many parameters (count = 4): useEmbeddedView	1

qltysh bot reviewed

View reviewed changes

src/embedded/components/IterableEmbeddedNotification/IterableEmbeddedNotification.tsx

+                      )}
+                    </View>
+                  </Pressable>
+                );

qltysh bot Feb 12, 2026

Function with high complexity (count = 7): IterableEmbeddedNotification [qlty:function-complexity]

src/embedded/hooks/useEmbeddedView/getMedia.ts Show resolved Hide resolved

src/embedded/hooks/useEmbeddedView/getStyles.ts Show resolved Hide resolved

src/embedded/hooks/useEmbeddedView/getStyles.ts Show resolved Hide resolved

src/embedded/hooks/useEmbeddedView/useEmbeddedView.ts

+               * @returns The embedded view.
+               *
+               * @example
+               * const { handleButtonClick, handleMessageClick, media, parsedStyles } = useEmbeddedView(IterableEmbeddedViewType.Notification, {

qltysh bot Feb 12, 2026

Found 3 issues:

1. tsdoc-escape-right-brace: The "}" character should be escaped using a backslash to avoid confusion with a TSDoc inline tag [eslint:tsdoc/syntax]

2. tsdoc-malformed-inline-tag: Expecting a TSDoc tag starting with "{@" [eslint:tsdoc/syntax]

3. tsdoc-malformed-inline-tag: Expecting a TSDoc tag starting with "{@" [eslint:tsdoc/syntax]

src/embedded/hooks/useEmbeddedView/useEmbeddedView.ts

+               *   config,
+               *   onButtonClick,
+               *   onMessageClick,
+               * });

qltysh bot Feb 12, 2026

tsdoc-escape-right-brace: The "}" character should be escaped using a backslash to avoid confusion with a TSDoc inline tag [eslint:tsdoc/syntax]

src/embedded/hooks/useEmbeddedView/useEmbeddedView.ts

+               *
+               * return (
+               *   <View>
+               *     <Text>{media.url}</Text>

qltysh bot Feb 12, 2026

Found 2 issues:

1. tsdoc-escape-right-brace: The "}" character should be escaped using a backslash to avoid confusion with a TSDoc inline tag [eslint:tsdoc/syntax]

2. tsdoc-malformed-inline-tag: Expecting a TSDoc tag starting with "{@" [eslint:tsdoc/syntax]

src/embedded/hooks/useEmbeddedView/useEmbeddedView.ts

+               * return (
+               *   <View>
+               *     <Text>{media.url}</Text>
+               *     <Text>{media.caption}</Text>

qltysh bot Feb 12, 2026

Found 2 issues:

1. tsdoc-escape-right-brace: The "}" character should be escaped using a backslash to avoid confusion with a TSDoc inline tag [eslint:tsdoc/syntax]

2. tsdoc-malformed-inline-tag: Expecting a TSDoc tag starting with "{@" [eslint:tsdoc/syntax]

src/embedded/hooks/useEmbeddedView/useEmbeddedView.ts

+               *   <View>
+               *     <Text>{media.url}</Text>
+               *     <Text>{media.caption}</Text>
+               *     <Text>{parsedStyles.backgroundColor}</Text>

qltysh bot Feb 12, 2026

Found 2 issues:

1. tsdoc-escape-right-brace: The "}" character should be escaped using a backslash to avoid confusion with a TSDoc inline tag [eslint:tsdoc/syntax]

2. tsdoc-malformed-inline-tag: Expecting a TSDoc tag starting with "{@" [eslint:tsdoc/syntax]

src/embedded/hooks/useEmbeddedView/useEmbeddedView.ts

+                  config,
+                  onButtonClick = () => {},
+                  onMessageClick = () => {},
+                }: IterableEmbeddedComponentProps

qltysh bot Feb 12, 2026

Function with many parameters (count = 4): useEmbeddedView [qlty:function-parameters]

Base automatically changed from loren/embedded/MOB-12270-new-embedded-view-component to emb-ootb/master

February 17, 2026 23:14


          Merge branch 'loren/embedded/SDK-367-parse-media-for-components' into…

f0cdd24

… loren/embedded/SDK-248-notification-component

lposen changed the base branch from emb-ootb/master to loren/embedded/SDK-367-parse-media-for-components

February 24, 2026 01:48

lposen added 2 commits

February 23, 2026 18:10


          test: add unit tests for IterableEmbeddedNotification component

8df3131


          refactor: remove media display logic

47a283d

lposen marked this pull request as ready for review

February 24, 2026 02:14

lposen changed the title ~~Loren/embedded/SDK-248-notification-component~~ [SDK-248] notification-component

qltysh bot reviewed

View reviewed changes

src/embedded/components/IterableEmbeddedView.tsx

-                    <Cmp {...props} />
-                  </View>
-                ) : null;
+                return Cmp ? <Cmp {...props} /> : null;

qltysh bot Feb 24, 2026

Found 2 issues:

1. Function with many returns (count = 5): IterableEmbeddedView [qlty:return-statements]

2. Function with high complexity (count = 5): IterableEmbeddedView [qlty:function-complexity]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet