-
Notifications
You must be signed in to change notification settings - Fork 67
fix: fix ray redundant execution #165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @ChenZiHong-Gavin, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses redundant execution issues within the Ray data processing pipeline by changing how intermediate results are handled. Instead of eagerly materializing datasets, the system now writes node outputs to JSON files and then lazily re-reads them. This approach, coupled with custom filename generation and consistent JSON serialization/deserialization of graph data, aims to improve efficiency and reduce unnecessary computations in the Ray-based graph generation process. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request effectively addresses potential redundant executions in the Ray-based data processing pipeline by introducing checkpointing. Intermediate datasets are now saved to disk and read back lazily, which breaks the computation graph and prevents re-computation. The refactoring moves the saving logic into the Engine class, improving encapsulation. The data serialization strategy has been updated to use JSON strings, ensuring compatibility with the write_json method. My review includes a couple of minor suggestions to improve code clarity and remove obsolete code.
| """ | ||
| logger.info("[Generation] mode: %s, batches: %d", self.method, len(items)) | ||
| items = [(item["nodes"], item["edges"]) for item in items] | ||
| # items = [(item["nodes"], item["edges"]) for item in items] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
…open-sciencelab/GraphGen into fix/fix-ray-redundant-execution
This PR addresses redundant execution issues within the Ray data processing pipeline by changing how intermediate results are handled. Instead of materializing datasets (occupying large memory), the system now uses disk cache by writing node outputs to JSON files and then lazily re-reading them.
When handling pipelines like below:

we can avoid ray's default redundant task execution.