This repository was archived by the owner on Mar 17, 2026. It is now read-only.
Open
Conversation
…t ffi native extensions can be installed correctly
Contributor
|
I think probably https://github.com/Instrumental/instrumental_agent-ruby/blob/master/lib/instrumental/agent.rb#L350-L356 needs to set failures to 0 if we have success in the read block, unless you intended the fix to be count failures since agent start? |
Contributor
Author
|
Totally reasonable. As it is now, it will count up until something forces run_worker_loop to exit, and then it will be reset on the next run, which is fine for the SSL problem we're working on now, but probably not ideal for softer failure modes. |
Contributor
|
I assume bd443c0 is what we've been using in prod for the last week-ish? |
Contributor
Author
|
Yes, prod is on 3.0.0.alpha, and looks good so far. |
janxious
reviewed
Sep 3, 2019
| @@ -3,4 +3,4 @@ source "https://rubygems.org" | |||
| gemspec | |||
|
|
|||
| # fixes 2.3.0 ffi bundle error | |||
Contributor
There was a problem hiding this comment.
I wish we could deprecate comments. This seems like it is nearing its sell-by date.
janxious
approved these changes
Sep 3, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.