Skip to content

Get error from helm wrapper#534

Draft
olevitt wants to merge 4 commits intomainfrom
get-error-from-helm
Draft

Get error from helm wrapper#534
olevitt wants to merge 4 commits intomainfrom
get-error-from-helm

Conversation

@olevitt
Copy link
Contributor

@olevitt olevitt commented Dec 12, 2024

Fix #533 : retrieve and properly log the error when installing a helm package

@github-actions github-actions bot added the helm-wrapper Related to the helm-wrapper library label Dec 12, 2024
Comment on lines +50 to +53
getProcessExecutor(errorStream)
.environment(getEnv(helmConfiguration))
.commandSplit(
addConfigToCommand(command, helmConfiguration) + " --output json")

Check notice

Code scanning / SonarCloud

OS commands should not be vulnerable to argument injection attacks

<!--SONAR_ISSUE_KEY:AZO7jwBcHy9G14eFYhWJ-->Change this code to not construct OS command arguments from user-controlled data. <p>See more on <a href="https://sonarcloud.io/project/issues?id=InseeFrLab_onyxia-api&issues=AZO7jwBcHy9G14eFYhWJ&open=AZO7jwBcHy9G14eFYhWJ&pullRequest=534">SonarQube Cloud</a></p>
Comment on lines +85 to +87
getProcessExecutor(errorStream)
.environment(getEnv(helmConfiguration))
.commandSplit(addConfigToCommand(command, helmConfiguration))

Check notice

Code scanning / SonarCloud

OS commands should not be vulnerable to argument injection attacks

<!--SONAR_ISSUE_KEY:AZO7j4bdeuttsEMcF9Af-->Change this code to not construct OS command arguments from user-controlled data. <p>See more on <a href="https://sonarcloud.io/project/issues?id=InseeFrLab_onyxia-api&issues=AZO7j4bdeuttsEMcF9Af&open=AZO7j4bdeuttsEMcF9Af&pullRequest=534">SonarQube Cloud</a></p>
@sonarqubecloud
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

helm-wrapper Related to the helm-wrapper library

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve logs, handling and parsing of Helm install erros

1 participant

Comments