Feature: Pattern matching for video titles#283
Closed
Blodroed wants to merge 2 commits intoInrixia:devfrom
Closed
Conversation
Owner
|
You can just use regex in
I don't see how this adds anything that isn't already supported. Happy to discuss further either here or on discord but I'm going to close this as it doesn't add anything you can't already do. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Was kinda bummed it did not have a pattern implementation, so here i suggest my own. Tested in a docker container, but without hard tests was kind of hard to tell if it would integrate well enough. But from what I have experienced it works pretty well.
There is options for both exclude and include patterns.
It is programmed to use the settings.json for patterns per channel, and not just per subscription.
It uses just plain text with wildcard "*" for patterns stored in the settings.json, while the program converts them to regex on startup.
There is a new section in the docs that explains the matching a little more in detail.