refactor: improve NamedModules API return type and expose named_modules wrapper #106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kilinchange
requested changes
Feb 8, 2026
Collaborator
|
麻烦运行一下测试脚本，并贴出 loss/tps 测试结果的截图。 |
Contributor
Author
baseline：20251223/feature/tp-pp-split-stream tps 测试结果： |
chen2021673
force-pushed
the
refactor_named_module
branch
from
1b137a9 to
de6cce7
Compare
kilinchange
requested changes
Feb 9, 2026
chen2021673
force-pushed
the
refactor_named_module
branch
from
de6cce7 to
7ad6863
Compare
- Rename private NamedModules() to use odered std::vector<std::pair> return type - Add public named_modules() wrapper with recurse/remove_duplicate params - Add BuildNameMap() to create module->name map for precision checking Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
chen2021673
force-pushed
the
refactor_named_module
branch
from
7ad6863 to
b97bf82
Compare
kilinchange
approved these changes
Feb 9, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR refactors the internal NamedModules API to use a more ordered and explicit return type, improves name lookup precision, and adds a public wrapper for convenience.
Why
Changes
NamedModules()to return an orderedstd::vector<std::pair<...>>instead of the old type.BuildNameMap()utility to build a stable module-to-name mapping.Result