Small tweaks to color scheme#61
Conversation
egrace479
left a comment
egrace479
left a comment
There was a problem hiding this comment.
Looks great, thank you! I just think the info should match notes as they're conceptually more similar and tips should stand out a bit more as distinct (FAIR Guide being one example page).
egrace479
left a comment
egrace479
left a comment
There was a problem hiding this comment.
Matching the accent color for active navigation URLs messes up the hover, so let's keep them matching the URLs in-text. I also noticed the outer level wasn't bolded, so that's included in the suggestion.
Co-authored-by: Elizabeth Campolongo <38985481+egrace479@users.noreply.github.com>
Makes sense, thank you! I applied your suggestions for the links. There is currently no visual difference between an active navigation item and a regular link, which is perhaps not great, but when working with themes like this sometimes you have to compromise. For the admonition colors, some problem with applying the suggestions (maybe conflicting code?), but I think I got the intention, so I made a separate commit. Now notes and info are using the primary style and questions and tips are using the accent style. I think that logic is making more sense, thank you! |
It is only the selected one that's highlighted (by the different color) and we have the ones that are scrolled past in a different shade of grey, so I think it's alright based on the site's structure. |
|
🙌 I think this is an improvement to the existing scheme proposed in #60! |
from main theme, not overridden
* Set color scheme to match ABC Colors Pull from ABC-Guide [PR 7](ABC-Center/ABC-guide#7) --------- Co-authored-by: Anna Viklund <annamariaviklund@gmail.com> * fix 18: set GitHub panel color to match on mobile/small screens Pull from ABC Guide [PR 19](ABC-Center/ABC-guide#19) --------- Co-authored-by: Anna Viklund <annamariaviklund@gmail.com> * Set colors to be more modular with some added instructions Use Imageomics Guide colors for light mode and ABC for dark mode * Add color-specification instructions * Try green-teal color scheme with purple accents * Implement suggested color scheme from #59 Co-authored-by: Anna Viklund <annamariaviklund@gmail.com> * Revise default color note to point to palette definition * Small tweaks to color scheme (#61) * Adjust colors for admonition tip * Adjust colors for small screen navigation * Make links more distinguishable * Adjust colors for admonition info * Tweak link appearance * Apply link tweak suggestions from code review Co-authored-by: Elizabeth Campolongo <38985481+egrace479@users.noreply.github.com> * Tweak logic for admonition colors * Set colors for summary component * Add background color definition clarification from main theme, not overridden --------- Co-authored-by: Elizabeth Campolongo <38985481+egrace479@users.noreply.github.com> * Add acknowledgment for Anna's help with color scheme --------- Co-authored-by: Anna Viklund <annamariaviklund@gmail.com>
[PR 60](Imageomics/Collaborative-distributed-science-guide#60) Implement new color scheme * Set colors to be more modular with some added instructions * Small tweaks to color scheme [PR 61](Imageomics/Collaborative-distributed-science-guide#61) * Adjust colors for admonition tip * Adjust colors for small screen navigation * Make links more distinguishable * Adjust colors for admonition info * Tweak link appearance * Apply link tweak suggestions from code review Co-authored-by: Elizabeth Campolongo <38985481+egrace479@users.noreply.github.com> * Tweak logic for admonition colors * Set colors for summary component * Add background color definition clarification from main theme, not overridden --------- Co-authored-by: Elizabeth Campolongo <38985481+egrace479@users.noreply.github.com> Co-authored-by: Anna Viklund <annamariaviklund@gmail.com>
3 participants
Summary of changes
Screenshots
Before:
After:
