Increase timeout and update configs#127
Merged
Tom-Willemsen merged 5 commits intomasterfrom Apr 2, 2025
Merged
Conversation
Tom-Willemsen
approved these changes
Apr 1, 2025
Member
Tom-Willemsen
left a comment
There was a problem hiding this comment.
ok to merge if you want, but a couple of small typing suggestions
|
|
||
|
|
||
| def parameterized_list(cases): | ||
| def parameterized_list(cases: list[Any]) -> list[tuple[str, Any]]: |
Member
There was a problem hiding this comment.
For future I think this could be typed as:
T = TypeVar("T")
def parameterized_list(cases: list[T]) -> list[tuple[str, T]]:
or similar
Member
Author
There was a problem hiding this comment.
if T is a tuple then i think it is slightly different as in
parameterized_list([(1,2)]) -> "(1,2)", 1, 2 as opposed to "(1,2)", (1,2)
so T is unpacked ... so is that potentially tuple[str, Any, ...] ?
Member
There was a problem hiding this comment.
I see... that case can probably be done with typing.overload and typing.Unpack, but happy enough with Any for the moment then (and since this is only really used by tests, maybe not worth going too overboard with it)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of work
Increase config load timeout for large memory test config
Ticket
Link to Ticket
Acceptance criteria
List the acceptance criteria for the PR. The aim is provide information to help the reviewer
Unit tests
Give an overview of unit tests you have added or modified, if applicable. The aim is provide information to help the reviewer
System tests
Mention any automated tests or manual tests that you have added or modified, if applicable. The aim is provide information to help the reviewer
Documentation
Highlight and provide a link to any additions or changes to the documentation, if applicable. The aim is provide information to help the reviewer
Code Review
Final Steps