Open
Conversation
dektar
requested changes
Feb 10, 2021
Contributor
dektar
left a comment
dektar
left a comment
There was a problem hiding this comment.
It'll be nice to have this functionality! Some comments below.
| * |color|. Each vertex is represented by it's x and y coordinate, and are | ||
| * listed sequentially in the vector. For example, a polygon with three | ||
| * vertices (0, 0), (0, 2), (2,1) is represented as a vector of integers | ||
| * {0, 0, 0, 2, 2, 1}. The last vertex will connect with the first vertex in |
Contributor
There was a problem hiding this comment.
It's a little hard to read this polygon vector, especially for large numbers of vertices. What do you think of making a simple graphics::Point class and having a std::vectorgraphics::Point instead?
You could also add a DrawTriangle that takes int x1, int y1, int x2, int y2, int x3, int y3 as that's probably the most common polygon that would be used.
| } | ||
| } | ||
| std::vector<int> points = {20, 20, 20, 22, 22, 21}; | ||
| image.DrawPolygon(points, red); |
Contributor
There was a problem hiding this comment.
can you add some polygon-speicifc tests: first, that drawing a polygon clockwise is the same as drawing the same thing counterclockwise? second, if drawing a rect is the same as drawing a polygon with four points?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hope I do the library justice :)