Improve API design with builder pattern and Java async conventions#232
Merged
andreadimaio merged 6 commits intomainfrom Apr 6, 2026
Merged
Improve API design with builder pattern and Java async conventions#232andreadimaio merged 6 commits intomainfrom
andreadimaio merged 6 commits intomainfrom
Conversation
andreadimaio
force-pushed
the
refactor/api-improvements
branch
2 times, most recently
from
2dd0602 to
ab7b0ea
Compare
…` method Changes: - Converted EmbeddingRequest from record to builder class for extensibility - Created EmbeddingPayload record for internal API requests - Added `embeddingAsync` method - Extracted Parameters and ReturnOptions to separate classes
Change async method naming from prefix to suffix pattern: - asyncToken() → tokenAsync() - asyncTokenize() → tokenizeAsync() - asyncDeleteFile() → deleteFileAsync()
Changes: - Converted RerankRequest from record to builder class for extensibility - Created RerankPayload record for internal API requests
andreadimaio
force-pushed
the
refactor/api-improvements
branch
from
ab7b0ea to
0e0ff1e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors several core APIs
EmbeddingRequestto builder patternRerankRequestto builder patternembeddingAsync()asyncToken()→tokenAsync()asyncTokenize()→tokenizeAsync()asyncDeleteFile()→deleteFileAsync()