UID2-6321 Add AKS related e2e test steps back#201
Open
cYKatherine wants to merge 23 commits intomainfrom
Open
Conversation
cYKatherine
force-pushed
the
kcc-UID2-6321-reenable-aks-e2e
branch
from
2911ae0 to
44f4a1c
Compare
cYKatherine
force-pushed
the
kcc-UID2-6321-reenable-aks-e2e
branch
from
a5b5f61 to
f9a1b00
Compare
cYKatherine
force-pushed
the
kcc-UID2-6321-reenable-aks-e2e
branch
from
81ad624 to
79ed936
Compare
cYKatherine
commented
Feb 18, 2026
| uses: actions/checkout@v4 | ||
| with: | ||
| ref: v3 | ||
| ref: kcc-UID2-6321-reenable-aks-e2e |
Contributor
Author
There was a problem hiding this comment.
Revert this to v3 before merging
cYKatherine
commented
Feb 18, 2026
| uses: actions/checkout@v4 | ||
| with: | ||
| ref: v3 | ||
| ref: kcc-UID2-6321-reenable-aks-e2e |
Contributor
Author
There was a problem hiding this comment.
Revert this to v3 before merging
lizk886
reviewed
Feb 20, 2026
| - name: Start AKS cluster | ||
| id: start_aks_cluster | ||
| if: ${{ inputs.operator_type == 'aks' }} | ||
| uses: IABTechLab/uid2-shared-actions/actions/start_aks_cluster@kcc-UID2-6321-reenable-aks-e2e |
Contributor
There was a problem hiding this comment.
will need to change here to version name as well
| E2E_EUID_PROD_AWS_OPERATOR_API_KEY: ${{ secrets.E2E_EUID_PROD_AWS_OPERATOR_API_KEY }} | ||
|
|
||
| E2E_UID2_INTEG_AKS_OPERATOR_KEY: ${{ secrets.E2E_UID2_INTEG_AKS_OPERATOR_KEY }} | ||
| E2E_UID2_PROD_AKS_OPERATOR_KEY: ${{ secrets.E2E_UID2_PROD_AKS_OPERATOR_KEY }} |
Contributor
There was a problem hiding this comment.
It's good practice to limit secrets to only the steps that require them.
| E2E_EUID_PROD_AWS_ARGS_JSON: ${{ secrets.E2E_EUID_PROD_AWS_ARGS_JSON }} | ||
| E2E_EUID_PROD_AWS_OPERATOR_API_KEY: ${{ secrets.E2E_EUID_PROD_AWS_OPERATOR_API_KEY }} | ||
|
|
||
| E2E_UID2_INTEG_AKS_OPERATOR_KEY: ${{ secrets.E2E_UID2_INTEG_AKS_OPERATOR_KEY }} |
Contributor
There was a problem hiding this comment.
This workflow can only be called with for a single combination of operator type, identity scope, and environment.
Why don't we just have the caller pass in the operator key and secret for that specific combination instead of having all these secrets and making the workflow pick the appropriate one (get_operator_key.sh)?
| RUN_ID: ${{ inputs.run_id }} | ||
| run: | | ||
| bash uid2-shared-actions/scripts/aks/prepare_aks_artifacts.sh | ||
| bash ${{ github.action_path }}/../../scripts/aks/prepare_aks_artifacts.sh |
Co-authored-by: Cursor <cursoragent@cursor.com>
cYKatherine
force-pushed
the
kcc-UID2-6321-reenable-aks-e2e
branch
from
7cfa322 to
f92beaf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since there are many changes, here's a summary of what's different from the previous behavior:
aks_env.shfor consistent naming across all scripts.${{ github.action_path }}relative paths, avoiding reference errors when the action is called from different branches.github-uidservice principal (dae96aa9-b4fb-473e-ae51-b817a571bfec)