Open
Conversation
ReadGDSIIFile.cc:622:19: warning: cast from 'libGDSII::BYTE *' (aka 'unsigned char *') to
'libGDSII::WORD *' (aka 'unsigned short *') increases required alignment from 1 to 2
[-Wcast-align]
WORD W = *(WORD *)Payload;
Rather than perform a pointer cast, just explicitly load two bytes and shift them
to make a 16-bit word. This has the additional advantage of being more portable,
because we can specify the endian-ness with which we read the data.
I used a little-endian order for backward compatibility with x86 machines.
(It's not clear to me whether the GDSII format specifies a particular
interpretation of bitfield indices, so that endianness matters here?)
ReadGDSIIFile.cc:654:50: warning: adding 'libGDSII::BYTE' (aka 'unsigned char') to a
string does not append to the string [-Wstring-plus-int]
*ErrMsg = new string("unknown data type " + DType);
~~~~~~~~~~~~~~~~~~~~~^~~~~~~
ReadGDSIIFile.cc:654:50: note: use array indexing to silence this warning
*ErrMsg = new string("unknown data type " + DType);
The std::string + char method does not apply to string literals, which are just
just pointers. Instead, just leave a placeholder character X in the string
and overwrite it with DType.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes two compiler warnings, which may indicate bugs:
Fixes warning:
Rather than perform a pointer cast, just explicitly load two bytes and shift them to make a 16-bit word. This has the additional advantage of being more portable, because we can specify the endian-ness with which we read the data. ( I used a little-endian order for backward compatibility with x86 machines. It's not clear to me whether the GDSII format specifies a particular interpretation of bitfield indices, so that endianness matters here?)
Also fix warning:
The
std::string + charmethod does not apply to string literals, which are just pointers. Instead, I just leave a placeholder character X in the string and overwrite it withDType.