Open
Conversation
=> because it is currently not part of nightly compiler
Harry-R
requested changes
Sep 16, 2019
| @@ -1,6 +1,5 @@ | |||
| use core::fmt; | |||
| use spin::Mutex; | |||
| use aarch64::io::*; | |||
Owner
There was a problem hiding this comment.
Why not using aarch64 crate here?
| // init 1G stack stack in RAM area (>0x40000000 for qemu virt device) | ||
| movz x1, 0x5000, lsl 16 | ||
| //movz x1, 0x5000, lsl 16 | ||
| ldr x1, =(boot_stack+0x2000-0x10) |
Owner
There was a problem hiding this comment.
Would be great, if you could explain this line in a comment above
|
|
||
| // init 1G stack stack in RAM area (>0x40000000 for qemu virt device) | ||
| movz x1, 0x5000, lsl 16 | ||
| //movz x1, 0x5000, lsl 16 |
Owner
There was a problem hiding this comment.
I'm not a friend of leaving unused code in the file, would suggest to remove it. For viewing the diff to the qemu-version, I will create a qemu-branch, so one could simply do git diff.
Suggested change
| //movz x1, 0x5000, lsl 16 |
Author
There was a problem hiding this comment.
Yes, removing is the better option
|
|
||
| /// Our primary serial port. | ||
| pub static COM1: Mutex<ComPort> = Mutex::new(ComPort::new(0x09000000)); | ||
| pub static mut COM1: ComPort = ComPort::new(0x800 /*0x09000000*/); |
Owner
There was a problem hiding this comment.
Suggested change
| pub static mut COM1: ComPort = ComPort::new(0x800 /*0x09000000*/); | |
| pub static mut COM1: ComPort = ComPort::new(0x800); |
| #![no_std] | ||
|
|
||
| extern crate spin; | ||
| //extern crate spin; |
Owner
There was a problem hiding this comment.
Suggested change
| //extern crate spin; |
|
|
||
| [dependencies] | ||
| spin = "0.4.9" # Spinlocks. | ||
| #spin = "0.4.9" # Spinlocks. |
Owner
There was a problem hiding this comment.
Suggested change
| #spin = "0.4.9" # Spinlocks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
eduos