[N/A] Hook up event propagation for all browserview-related events by MichaelMCoates · Pull Request #357 · HadoukenIO/js-adapter

MichaelMCoates · 2019-10-02T17:11:11Z

Description of Change

This PR adds propagated events up to Application and System for BrowserView.

Tests:
https://testing-dashboard.openfin.co/#/app/sessions/api/completed/5da8b1ceee166d7a14d451bc

Corresponding core PR:
HadoukenIO/core#976

@aziz512 trying to add you as reviewer but it won't let me for some reason.

Checklist

PR description included and stakeholders cc'd
npm test passes
automated tests are changed or added
relevant documentation is changed or added
Link to new tests added
PR has assigned reviewers

Release Notes

Notes:

openfin-github-bot · 2019-10-02T17:57:07Z

eae221f

Git

core: develop <= dev/coates/bv-event-propagation (c7afb49)
js-adapter: develop <= dev/coates/bv-event-propagation (eae221f)
javascript-adapter: develop

Asars used for testing

Test results

✅ Windows 7 (32-bit runtime): Failed 0/665
😰 Windows 7 (64-bit runtime): Failed 1/665
✅ Windows 10 (64-bit runtime): Failed 0/665
😰 Windows 10 (32-bit runtime): Failed 2/665

openfin-github-bot · 2019-10-10T00:49:15Z

⚠️ Failed to build `87dedcf`

openfin-github-bot · 2019-10-10T17:50:07Z

f231be5

Git

core: develop <= dev/coates/bv-event-propagation (99ab0e7)
js-adapter: develop <= dev/coates/bv-event-propagation (f231be5)
javascript-adapter: develop

Asars used for testing

Test results

✅ Windows 7 (32-bit runtime): Failed 0/665
✅ Windows 7 (64-bit runtime): Failed 0/665
✅ Windows 10 (32-bit runtime): Failed 0/665
✅ Windows 10 (64-bit runtime): Failed 0/665

licui3936 · 2019-10-16T19:43:09Z

+    'window-view-hidden': WindowEvent<Topic, Type>;
+    'window-view-page-favicon-updated': WindowEvent<Topic, Type>;
+    'window-view-page-title-updated': WindowEvent<Topic, Type>;
+    'view-resource-load-failed': WindowResourceLoadFailedEvent<Topic, Type>;


'window' is missing in the event name?

licui3936 · 2019-10-16T19:43:19Z

+    'window-view-page-favicon-updated': WindowEvent<Topic, Type>;
+    'window-view-page-title-updated': WindowEvent<Topic, Type>;
+    'view-resource-load-failed': WindowResourceLoadFailedEvent<Topic, Type>;
+    'view-resource-response-received': WindowResourceResponseReceivedEvent<Topic, Type>;


licui3936 · 2019-10-16T19:46:18Z

 * window-start-load
 * window-user-movement-disabled (see {@tutorial Window.EventEmitter})
 * window-user-movement-enabled (see {@tutorial Window.EventEmitter})
+* window-view-attached (see {@tutorial Window.EventEmitter})


@tutorial Window.EventEmitter => @tutorial BrowserView.EventEmitter

licui3936 · 2019-10-16T19:46:41Z

+* window-view-crashed (see {@tutorial BrowserView.EventEmitter})
+* window-view-created (see {@tutorial BrowserView.EventEmitter})
+* window-view-destroyed (see {@tutorial BrowserView.EventEmitter})
+* window-view-detached (see {@tutorial Window.EventEmitter})


All fixed. Thank you!

openfin-github-bot · 2019-10-17T17:42:07Z

ad6048c

Git

core: develop <= dev/coates/bv-event-propagation (bad0f85)
js-adapter: develop <= dev/coates/bv-event-propagation (ad6048c)
javascript-adapter: develop

Asars used for testing

Test results

😱 Windows 10 (32-bit runtime): Failed 3/668
😱 Windows 7 (32-bit runtime): Failed 5/668
😱 Windows 10 (64-bit runtime): Failed 5/668
😱 Windows 7 (64-bit runtime): Failed 19/668

MichaelMCoates · 2019-10-17T18:32:54Z

After talking with Pierre and Tommy, changed the eventing scheme to the following:

Windows can listen to view-attached and view-detached.
Views can listen to target-changed.
Window view events don't propagate up to Application and System.
All view events propagate up to Window, Application, and System.

The tests have been updated to reflect these changes.

openfin-github-bot · 2019-10-17T19:42:06Z

2289f59

Git

core: develop <= dev/coates/bv-event-propagation (f877a7f)
js-adapter: develop <= dev/coates/bv-event-propagation (2289f59)
javascript-adapter: develop

Asars used for testing

Test results

😱 Windows 7 (32-bit runtime): Failed 3/667
😰 Windows 10 (32-bit runtime): Failed 2/667
😱 Windows 7 (64-bit runtime): Failed 6/667
😱 Windows 10 (64-bit runtime): Failed 224/667

Hook up event propagation for all browserview-related events

eae221f

MichaelMCoates requested review from datamadic, pbaize and rdepena October 2, 2019 17:11

finos-admin added the cla-present label Oct 2, 2019

MichaelMCoates mentioned this pull request Oct 2, 2019

[N/A] Hook up event propagation for all browserview-related events HadoukenIO/core#976

Open

6 tasks

MichaelMCoates changed the title ~~[N/A] Hook up event propagation for all browserview-related events~~ DO NOT REVIEW YET [N/A] Hook up event propagation for all browserview-related events Oct 2, 2019

openfin-github-bot Bot added the auto testing started Bot started automated testing label Oct 2, 2019

openfin-github-bot Bot added auto testing done Bot completed automated testing and removed auto testing started Bot started automated testing labels Oct 2, 2019

Add propagated view events in documentation and mappings

87dedcf

aziz512 self-requested a review October 9, 2019 23:22

openfin-github-bot Bot added auto testing failed Bot failed to build and removed auto testing done Bot completed automated testing labels Oct 10, 2019

Empty commit

f231be5

openfin-github-bot Bot added auto testing started Bot started automated testing and removed auto testing failed Bot failed to build labels Oct 10, 2019

openfin-github-bot Bot added auto testing done Bot completed automated testing and removed auto testing started Bot started automated testing labels Oct 10, 2019

MichaelMCoates changed the title ~~DO NOT REVIEW YET [N/A] Hook up event propagation for all browserview-related events~~ [N/A] Hook up event propagation for all browserview-related events Oct 11, 2019

dhamberlin previously approved these changes Oct 11, 2019

View reviewed changes

licui3936 reviewed Oct 16, 2019

View reviewed changes

Documentation changes and event name fix

03d337a

MichaelMCoates dismissed dhamberlin’s stale review via 03d337a October 17, 2019 16:49

Add target to payload of webcontents events

ad6048c

openfin-github-bot Bot added auto testing started Bot started automated testing and removed auto testing done Bot completed automated testing labels Oct 17, 2019

openfin-github-bot Bot added auto testing done Bot completed automated testing and removed auto testing started Bot started automated testing labels Oct 17, 2019

Change eventing to target-changed and view-attached/detached for windows

2289f59

openfin-github-bot Bot added auto testing started Bot started automated testing and removed auto testing done Bot completed automated testing labels Oct 17, 2019

openfin-github-bot Bot added auto testing done Bot completed automated testing and removed auto testing started Bot started automated testing labels Oct 17, 2019

MichaelMCoates closed this Nov 4, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[N/A] Hook up event propagation for all browserview-related events#357

[N/A] Hook up event propagation for all browserview-related events#357
MichaelMCoates wants to merge 6 commits intoHadoukenIO:developfrom
MichaelMCoates:dev/coates/bv-event-propagation

MichaelMCoates commented Oct 2, 2019 •

edited

Loading

Uh oh!

openfin-github-bot Bot commented Oct 2, 2019

Uh oh!

openfin-github-bot Bot commented Oct 10, 2019

Uh oh!

openfin-github-bot Bot commented Oct 10, 2019

Uh oh!

licui3936 Oct 16, 2019

Uh oh!

licui3936 Oct 16, 2019

Uh oh!

licui3936 Oct 16, 2019

Uh oh!

licui3936 Oct 16, 2019

Uh oh!

MichaelMCoates Oct 17, 2019

Uh oh!

openfin-github-bot Bot commented Oct 17, 2019

Uh oh!

MichaelMCoates commented Oct 17, 2019 •

edited

Loading

Uh oh!

openfin-github-bot Bot commented Oct 17, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

MichaelMCoates commented Oct 2, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description of Change

Checklist

Release Notes

Uh oh!

openfin-github-bot Bot commented Oct 2, 2019

Git

Asars used for testing

Test results

Uh oh!

openfin-github-bot Bot commented Oct 10, 2019

⚠️ Failed to build 87dedcf

Uh oh!

openfin-github-bot Bot commented Oct 10, 2019

Git

Asars used for testing

Test results

Uh oh!

licui3936 Oct 16, 2019

Choose a reason for hiding this comment

Uh oh!

licui3936 Oct 16, 2019

Choose a reason for hiding this comment

Uh oh!

licui3936 Oct 16, 2019

Choose a reason for hiding this comment

Uh oh!

licui3936 Oct 16, 2019

Choose a reason for hiding this comment

Uh oh!

MichaelMCoates Oct 17, 2019

Choose a reason for hiding this comment

Uh oh!

openfin-github-bot Bot commented Oct 17, 2019

Git

Asars used for testing

Test results

Uh oh!

MichaelMCoates commented Oct 17, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openfin-github-bot Bot commented Oct 17, 2019

Git

Asars used for testing

Test results

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

MichaelMCoates commented Oct 2, 2019 •

edited

Loading

⚠️ Failed to build `87dedcf`

MichaelMCoates commented Oct 17, 2019 •

edited

Loading