Skip to content

Fix fill node solid colour backup update#4159

Open
Annonnymmousss wants to merge 2 commits into
GraphiteEditor:masterfrom
Annonnymmousss:fix/fill-solid-backup
Open

Fix fill node solid colour backup update#4159
Annonnymmousss wants to merge 2 commits into
GraphiteEditor:masterfrom
Annonnymmousss:fix/fill-solid-backup

Conversation

@Annonnymmousss
Copy link
Copy Markdown
Contributor

@Annonnymmousss Annonnymmousss commented May 18, 2026

closes #3824

When the colour changes, we now compute the new fill value once and save that same new value both as the active Fill and into the correct backup slot.

Screen.Recording.2026-05-18.at.4.05.03.PM.mov

@Annonnymmousss Annonnymmousss marked this pull request as ready for review May 18, 2026 10:53
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the on_update closure for color inputs in the node graph properties to streamline how backup and active fill values are updated. A review comment suggests further simplifying the logic by extracting the backup index and value into a separate match expression, which would reduce code duplication and improve maintainability.

Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fill node solid colour backup resets when just clicked

1 participant