fix: move save state updates to SavedDocument handler #3567
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Why the new workflow? That seems unrelated. Converted to draft because this not ready for review. |
Fixes GraphiteEditor#3558 - Cancelling document saving leads to content/modifications being lost Previously, set_save_state(true) was called in the SaveDocument handler before the save dialog even appeared. This caused the document to be marked as saved even if the user cancelled the save dialog. Now the save state updates (set_save_state, set_auto_save_state) are called in the SavedDocument handler, which only executes after the file has actually been written to disk. This ensures that: - Cancelling the save dialog keeps the document marked as unsaved - The asterisk indicator remains visible until the file is truly saved - No content/modifications are lost if the save is cancelled
theaniketgiri
force-pushed
the
fix/save-cancel-dialog-3558
branch
from
e2f2a87 to
9fe0778
Compare
Author
You're absolutely right - both the workflow file and pnpm-lock were accidentally included. They were from a different branch I was working on and got mixed in when I created this PR. I've fixed this now: Rebased the branch onto master (2fa958a) |
timon-schelling
force-pushed
the
master
branch
from
124235a to
a42cad8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3558
Problem
Previously,
set_save_state(true)was called in theSaveDocumenthandler before the save dialog even appeared. This caused the document to be marked as saved even if the user cancelled the save dialog, leading to:Solution
Moved the save state updates (
set_save_state,set_auto_save_state) from theSaveDocumenthandler to theSavedDocumenthandler, which only executes after the file has actually been written to disk.Changes
set_save_state(true)and related calls fromSaveDocumenthandlerset_save_state(true)andset_auto_save_state(true)toSavedDocumenthandlerUpdateOpenDocumentsListresponse toSavedDocumenthandlerTesting
cargo check