This repository was archived by the owner on Jun 3, 2025. It is now read-only.
feat: Add an command line option to exclude root directory in the tar…#3425
Open
zhiyuan-chn wants to merge 1 commit intoGoogleContainerTools:mainfrom
Open
feat: Add an command line option to exclude root directory in the tar…#3425zhiyuan-chn wants to merge 1 commit intoGoogleContainerTools:mainfrom
zhiyuan-chn wants to merge 1 commit intoGoogleContainerTools:mainfrom
Conversation
…ball Fixes GoogleContainerTools#1375 Signed-off-by: Zhiyuan Chen <zhiyuan.ch3n@gmail.com>
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat: Add an option to exclude root directory in tarball
Fixes #1375
Description
The issue is that images built by Kaniko cannot be pulled successfully by Flux because Kaniko adds an absolute directory path “/” which tar program used by Flux doesn’t allow.
This PR adds a new command line option
--exclude-root-dir-tarballto allow excluding root directory in the tar archive.Testing done:
flux pull artifact <oci>works properly.Here are a few references about how the verification was performed.
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Reviewer Notes
Release Notes
Describe any changes here so maintainer can include it in the release notes, or delete this block.