chore(deps): update dependency protobuf to v7 - autoclosed#14162
chore(deps): update dependency protobuf to v7 - autoclosed#14162renovate-bot wants to merge 1 commit into
Conversation
trusted-contributions-gcf
Bot
added
kokoro:force-run
product-auto-label
Bot
added
samples
kokoro-team
removed
the
kokoro:force-run
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the protobuf dependency to version 7.34.1 across several requirements.txt files. The review feedback indicates that this version is likely incorrect for the Python ecosystem and will cause VersionConflict or runtime errors due to incompatibilities with other pinned Google Cloud libraries, such as google-api-core, google-cloud-datastore, and google-cloud-secret-manager.
| google-cloud-datastore==2.20.2 | ||
| google-api-core==2.17.1 | ||
| protobuf==4.25.8 | ||
| protobuf==7.34.1 |
There was a problem hiding this comment.
The version 7.34.1 for the protobuf package is likely incorrect for a Python environment, as the current major version on PyPI is 5.x. This major version jump is incompatible with the pinned versions of google-api-core==2.17.1 and google-cloud-datastore==2.20.2 in this file, which will lead to VersionConflict errors during installation or runtime failures.
| google-events==0.14.0 | ||
| google-api-core==2.17.1 | ||
| protobuf==4.25.6 | ||
| protobuf==7.34.1 |
There was a problem hiding this comment.
Updating protobuf to 7.34.1 while keeping google-api-core==2.17.1 is expected to cause compatibility issues. Major version mismatches in the protobuf runtime are a common source of TypeError and AttributeError in Google Cloud client libraries, as the generated code API often changes between major versions.
| @@ -1,2 +1,2 @@ | |||
| google-cloud-aiplatform[all]==1.64.0 | |||
| protobuf==5.29.5 | |||
| protobuf==7.34.1 | |||
There was a problem hiding this comment.
The version 7.34.1 for protobuf is non-standard for Python and likely incompatible with google-cloud-aiplatform[all]==1.64.0. This change will likely break the dependency resolution or cause runtime errors due to the significant version jump from the previous 5.29.5.
| @@ -1,4 +1,4 @@ | |||
| protobuf==5.29.4 | |||
| protobuf==7.34.1 | |||
There was a problem hiding this comment.
The version 7.34.1 for protobuf is likely incorrect for a Python environment and incompatible with google-api-core==2.23.0. Major version mismatches in the protobuf runtime often result in VersionConflict during dependency resolution or runtime failures in the managedkafka snippets.
| google-cloud-secret-manager==2.24.0 | ||
| google-crc32c==1.6.0 | ||
| protobuf==5.29.4 | ||
| protobuf==7.34.1 |
There was a problem hiding this comment.
This update to protobuf==7.34.1 is likely to break compatibility with google-cloud-secret-manager==2.24.0. Major version bumps in protobuf typically require a coordinated update of all dependent Google Cloud libraries to ensure the generated code remains compatible with the runtime environment.
renovate-bot
changed the title
2 participants
This PR contains the following updates:
==5.29.4→==7.34.1==5.29.5→==7.34.1==4.25.6→==7.34.1==4.25.8→==7.34.1Configuration
📅 Schedule: (UTC)
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Never, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about these updates again.
This PR was generated by Mend Renovate. View the repository job log.