Updated SID lookup to use ldap queries instead of LSA#53
Open
LuemmelSec wants to merge 2 commits intoGhostPack:mainfrom
Open
Updated SID lookup to use ldap queries instead of LSA#53LuemmelSec wants to merge 2 commits intoGhostPack:mainfrom
LuemmelSec wants to merge 2 commits intoGhostPack:mainfrom
Conversation
Now using ldap queries rather than LSA lookups. Needed for running from non domain joined systems
Added extraction of NetBIOS domain name from distinguished name.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In almost every engagement the tool is run off a host that is NOT domain joined via runas.
However, the SID resolution failed:
The code uses
SecurityIdentifier.Translate(typeof(NTAccount))which relies on the local LSA for resolving SIDs. On non-domain joined systems, this fails even with domain credentials via runas.Hence LDAP based resolution was implemented to overcome these limitations.