Skip to content

WIP: Update to node 12#279

Open
javihernandez wants to merge 14 commits intoGPII:masterfrom
javihernandez:node12
Open

WIP: Update to node 12#279
javihernandez wants to merge 14 commits intoGPII:masterfrom
javihernandez:node12

Conversation

@javihernandez
Copy link
Member

@javihernandez javihernandez commented Oct 10, 2019

Do not merge, I just want to pass this through CI

@gpii-bot
Copy link

gpii-bot commented Oct 10, 2019

CI job passed: https://ci.gpii.net/job/windows-tests/1051/

@amatas
Copy link

amatas commented Oct 11, 2019

ok to test

Just to check if the new VM is working properly.

@gpii-bot
Copy link

gpii-bot commented Oct 11, 2019

CI job failed: https://ci.gpii.net/job/windows-tests/1052/

@javihernandez
Copy link
Member Author

javihernandez commented Oct 11, 2019

CI job failed: https://ci.gpii.net/job/windows-tests/1052/

@stegru ^
@amatas we should wait until we find some time to figure out what's going on.

@amatas
Copy link

amatas commented Oct 14, 2019

ok to test

This time is using the old VM image. The new image has been deleted because of the new errors.

@gpii-bot
Copy link

gpii-bot commented Oct 14, 2019

CI job passed: https://ci.gpii.net/job/windows-tests/1054/

@gpii-bot
Copy link

gpii-bot commented May 10, 2020

CI job failed: https://ci.gpii.net/job/windows-tests/1379/

@gpii-bot
Copy link

gpii-bot commented May 10, 2020

CI job failed: https://ci.gpii.net/job/windows-tests/1380/

@gpii-bot
Copy link

gpii-bot commented May 10, 2020

CI job failed: https://ci.gpii.net/job/windows-tests/1381/

@gpii-bot
Copy link

gpii-bot commented May 11, 2020

CI job failed: https://ci.gpii.net/job/windows-tests/1382/

@gpii-bot
Copy link

gpii-bot commented May 11, 2020

CI job failed: https://ci.gpii.net/job/windows-tests/1383/

@javihernandez
node12: Updated ref reference
6d986d3
@javihernandez
Merge branch 'upstream/master' into node12
9b83367 
* upstream/master: (211 commits)
  NOJIRA: Fixed typo
  GPII-4231: Updating to version of universal with narrator autostart commented out
  GPII-3830: Mocking a wrapper fs.existsSync, rather than the real function.
  GPII-3830: Testing for unmounted usb drives
  GPII-4231: Adopted suggestion for mambo
  Revert "GPII-4428: Restoring icon spacing when restarting explorer."
  GPII-4428: Restoring icon spacing when restarting explorer.
  GPII-4231: Adding back one piece of mamba
  GPII-4231: Removing mamba
  GPII-4420: Handling the possibility of no installed language packs
  GPII-4420: Only listing languages installed by a morphic language installer
  GPII-4409: Improved test stability (increased timeout)
  GPII-4409: Refactored away null-array return of getProcessWindows
  GPII-4409: Launch buttons to activate existing application instance.
  GPII-4409: Getting the list of process windows, extracted from closeProcessByName for re-use.
  GPII-4382: Consistent with current universal master with fixed schemas
  GPII-4382: Added additional logging for SPI settings handler issues.
  GPII-4370: Rejecting settings handler if the settings helper fails.
  GPII-4382: Updated to use universal branch to test work in progress in CI.
  NOJIRA: Skipping service tests if running from electron.
  ...
@javihernandez
node12: Updated to node 12.16.3
7b94905
@javihernandez
node12: Updated to a version of the os-service with support for node 12
c95b5e0
@gpii-bot
Copy link

gpii-bot commented May 11, 2020

CI job failed: https://ci.gpii.net/job/windows-tests/1386/

@gpii-bot
Copy link

gpii-bot commented May 11, 2020

CI job failed: https://ci.gpii.net/job/windows-tests/1387/

@gpii-bot
Copy link

gpii-bot commented May 11, 2020

CI job passed: https://ci.gpii.net/job/windows-tests/1388/

@javihernandez
Copy link
Member Author

javihernandez commented May 11, 2020

ok to test

@gpii-bot
Copy link

gpii-bot commented May 11, 2020

CI job failed: https://ci.gpii.net/job/windows-tests/1389/

@javihernandez
Copy link
Member Author

javihernandez commented May 11, 2020

CI job failed: https://ci.gpii.net/job/windows-tests/1389/

13:02:51.903:  jq: Expected: {
    "gpii.windows.enableRegisteredAT": {
        "com.microsoft.windows.magnifier": [
            {
                "settings": {
                    "running": true
                }
            }
        ],
        "com.microsoft.windows.onscreenKeyboard": [
            {
                "settings": {
                    "running": false
                }
            }
        ]
    }
}
13:02:51.904:  jq: Actual: {
    "gpii.windows.enableRegisteredAT": {
        "com.microsoft.windows.magnifier": [
            {
                "settings": {
                    "running": undefined
                }
            }
        ],
        "com.microsoft.windows.onscreenKeyboard": [
            {
                "settings": {
                    "running": false
                }
            }
        ]
    }
}

Unrelated issue when turning the magnifier on - ok to test

@gpii-bot
Copy link

gpii-bot commented May 11, 2020

CI job passed: https://ci.gpii.net/job/windows-tests/1390/

@javihernandez
Copy link
Member Author

javihernandez commented May 11, 2020

ok to test

@gpii-bot
Copy link

gpii-bot commented May 12, 2020

CI job passed: https://ci.gpii.net/job/windows-tests/1391/

@amb26
Copy link
Member

amb26 commented Jun 10, 2020

Looks reasonable - do we need to publish scoped versions of all the forked ref-* stuff in npm?

@javihernandez
Copy link
Member Author

javihernandez commented Jun 16, 2020

Looks reasonable - do we need to publish scoped versions of all the forked ref-* stuff in npm?

First I'd like to check whether we can move to napi-equivalent ref deps (it wasn't the case some time ago); if there's no luck, yes, we then need to publish our scoped packages

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@javihernandez @gpii-bot @amatas @amb26