GPII-3066: Stop acceptance tests crashing

[stegru]

Fixes a random crash.

[gpii-bot]

CI job failed: https://ci.gpii.net/job/windows-tests/499/

[stegru]

ok to test

Unrelated error:

npm ERR! code EINTEGRITY
npm ERR! sha1-0Ng2s0OqbbiMDez+rnHmJ11BQg4= integrity checksum failed when using sha1: wanted sha1-0Ng2s0OqbbiMDez+rnHmJ11BQg4= but got sha1-6PszGsIWbEqnxlBbBaCvjw8e6i0=. (7322378 bytes)

[gpii-bot]

CI job passed: https://ci.gpii.net/job/windows-tests/500/

[gpii-bot]

CI job passed: https://ci.gpii.net/job/windows-tests/501/

[gpii-bot]

CI job failed: https://ci.gpii.net/job/windows-tests/516/

[stegru]

The last fail is unrelated.
ok to test

npm ERR! code EINTEGRITY
npm ERR! sha512-k6TIR8mTns3p35Q5knx+HZZpr3748S7nMiZqkAb4zg+xR1c2vRYSMegi5wWeYuBLe14AP0yTmamYu9eQsnCBDw== integrity checksum failed when using sha512: wanted sha512-k6TIR8mTns3p35Q5knx+HZZpr3748S7nMiZqkAb4zg+xR1c2vRYSMegi5wWeYuBLe14AP0yTmamYu9eQsnCBDw== but got sha512-OSSOtYx3iPgVkObZcAXMf8C9997ch+yI265PFFbE7IoqGwuzle83Q/gQG6qY2KbP2cdyZ5XXChHDo4fMrcsJOA==. (6413062 bytes)

npm ERR! A complete log of this run can be found in:
npm ERR!     C:\Users\vagrant\AppData\Roaming\npm-cache\_logs\2018-06-05T10_19_48_150Z-debug.log
Installation process returned error code: 1
At C:\tmp\Provisioning.psm1:44 char:5
+     throw "Installation process returned error code: $($exitCode)"
+     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : OperationStopped: (Installation pr...d error code: 1:String) [], RuntimeException
    + FullyQualifiedErrorId : Installation process returned error code: 1

Build step 'Execute shell' marked build as failure
Finished: FAILURE

[gpii-bot]

CI job failed: https://ci.gpii.net/job/windows-tests/517/

[gpii-bot]

CI job passed: https://ci.gpii.net/job/windows-tests/518/

[stegru]

Acceptance tests now legitimately pass.

05:23:06.295:  jq: ***************
05:23:06.295:  jq: All tests concluded: 30/30 total passed in 57218ms - PASS
05:23:06.295:  jq: ***************
Sending e-mails to: ci@lists.gpii.net
Finished: SUCCESS

[klown]

Thanks @stegru for alerting me to these changes. It fixes acceptance test in CI for two of my pull requests, #121 and #134.

👍