-
Notifications
You must be signed in to change notification settings - Fork 1
feat: Added classic snap packaging #294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kenvandine
wants to merge
1
commit into
FrameworkComputer:main
Choose a base branch
from
kenvandine:snap_packaging
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+89
−0
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,55 @@ | ||
| name: framework-tool | ||
| base: core24 | ||
| adopt-info: framework-tool | ||
| summary: CLI tool to inspect and control Framework Computer systems | ||
| description: | | ||
| framework_tool is a CLI utility to interact with Framework Computer laptop | ||
| and desktop firmware and hardware. Features include: | ||
| . | ||
| - Firmware inspection and updates (BIOS, EC, PD controllers, retimers) | ||
| - System status monitoring (power, thermal, sensors, USB-C ports) | ||
| - Hardware configuration (keyboard backlight, battery charge limits, fan control) | ||
| - Expansion card management (HDMI/DP/audio cards) | ||
| - Framework 16 specific features (input deck, expansion bay) | ||
| - NVIDIA GPU support | ||
| . | ||
| Note: Most features require root privileges (sudo framework-tool ...). | ||
|
|
||
| grade: stable | ||
| confinement: classic | ||
| compression: lzo | ||
|
|
||
| parts: | ||
| framework-tool: | ||
| plugin: rust | ||
| source: . | ||
| build-packages: | ||
| - libhidapi-dev | ||
| - libusb-1.0-0-dev | ||
| - libudev-dev | ||
| - pkg-config | ||
| stage-packages: | ||
| - libhidapi-hidraw0 | ||
| - libusb-1.0-0 | ||
| - libudev1 | ||
| override-pull: | | ||
| craftctl default | ||
| VERSION=$(craftctl get version) | ||
| if [ -z $VERSION ]; then | ||
| VERSION=$(git describe --tags --abbrev=10) | ||
| craftctl set version=$VERSION | ||
| fi | ||
| override-build: | | ||
| cd "${CRAFT_PART_SRC}" | ||
| cargo build --release -p framework_tool --features nvidia | ||
| install -Dm755 target/release/framework_tool "${CRAFT_PART_INSTALL}/bin/framework_tool" | ||
| install -Dm644 "${CRAFT_PART_SRC}/completions/bash/framework_tool" \ | ||
| "${CRAFT_PART_INSTALL}/share/bash-completion/completions/framework_tool" | ||
| install -Dm644 "${CRAFT_PART_SRC}/completions/zsh/_framework_tool" \ | ||
| "${CRAFT_PART_INSTALL}/share/zsh/site-functions/_framework_tool" | ||
| install -Dm644 "${CRAFT_PART_SRC}/completions/fish/framework_tool.fish" \ | ||
| "${CRAFT_PART_INSTALL}/share/fish/vendor_completions.d/framework_tool.fish" | ||
|
|
||
| apps: | ||
| framework-tool: | ||
| command: bin/framework_tool | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that changes the executable name to hyphen instead of underscore?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The snap name/app-name doesn't allow underscores as it means something different to snapd. Snaps can have different versions installed in parallel, and that "instances" are determined with an underscore.