chore: fix-publish-dirs by ryanbas21 · Pull Request #552 · ForgeRock/ping-javascript-sdk

ryanbas21 · 2026-03-19T20:43:09Z

JIRA Ticket

https://pingidentity.atlassian.net/browse/SDKS-4859

Description

Fixes directories in published packages

Summary by CodeRabbit

Chores
- Added MIT License files to multiple packages
- Updated package publishing configuration to include distributed build artifacts while excluding internal build metadata files

changeset-bot · 2026-03-19T20:43:18Z

⚠️ No Changeset found

Latest commit: b7987e6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

coderabbitai · 2026-03-19T20:43:24Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 0f49f3b7-d7cd-4957-971f-a40214d37a40

📥 Commits

Reviewing files that changed from the base of the PR and between e239060 and b7987e6.

📒 Files selected for processing (22)

packages/davinci-client/package.json
packages/device-client/package.json
packages/journey-client/LICENSE
packages/journey-client/package.json
packages/oidc-client/LICENSE
packages/oidc-client/package.json
packages/protect/LICENSE
packages/protect/package.json
packages/sdk-effects/iframe-manager/LICENSE
packages/sdk-effects/iframe-manager/package.json
packages/sdk-effects/logger/LICENSE
packages/sdk-effects/logger/package.json
packages/sdk-effects/oidc/LICENSE
packages/sdk-effects/oidc/package.json
packages/sdk-effects/sdk-request-middleware/LICENSE
packages/sdk-effects/sdk-request-middleware/package.json
packages/sdk-effects/storage/LICENSE
packages/sdk-effects/storage/package.json
packages/sdk-types/LICENSE
packages/sdk-types/package.json
packages/sdk-utilities/LICENSE
packages/sdk-utilities/package.json

📝 Walkthrough

Walkthrough

This PR standardizes license and npm publishing configuration across multiple packages by adding MIT License files and updating package.json "files" fields to include dist directories while excluding TypeScript build metadata artifacts.

Changes

Cohort / File(s)	Summary
LICENSE Files `packages/journey-client/LICENSE`, `packages/oidc-client/LICENSE`, `packages/protect/LICENSE`, `packages/sdk-effects/iframe-manager/LICENSE`, `packages/sdk-effects/logger/LICENSE`, `packages/sdk-effects/oidc/LICENSE`, `packages/sdk-effects/sdk-request-middleware/LICENSE`, `packages/sdk-effects/storage/LICENSE`, `packages/sdk-types/LICENSE`, `packages/sdk-utilities/LICENSE`	Added MIT License files with 2025 Ping Identity Corporation copyright notices and standard permission/warranty clauses.
Package.json Files Field (Existing Packages) `packages/davinci-client/package.json`, `packages/device-client/package.json`, `packages/journey-client/package.json`, `packages/oidc-client/package.json`, `packages/protect/package.json`, `packages/sdk-types/package.json`, `packages/sdk-utilities/package.json`	Updated `files` array to include `dist` with explicit exclusion of `dist/tsconfig.lib.tsbuildinfo`; davinci-client removes explicit `./LICENSE` entry.
Package.json Files Field (SDK Effects Packages) `packages/sdk-effects/iframe-manager/package.json`, `packages/sdk-effects/logger/package.json`, `packages/sdk-effects/oidc/package.json`, `packages/sdk-effects/sdk-request-middleware/package.json`, `packages/sdk-effects/storage/package.json`	Added `files` field to restrict published contents to `dist` while excluding `dist/tsconfig.lib.tsbuildinfo`.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Possibly related PRs

chore: publish-only-dist-jc #509: Modifies packages/journey-client/package.json's publish "files" setting following similar pattern to establish dist-only publishing.
chore: version-2-make-private-packages-public #502: Updates packaging configuration for device-client and journey-client packages, making them public by removing "private" flag alongside distribution adjustments.
chore(oidc-client): re-export necessary types #495: Updates packages/oidc-client package metadata and related exports, involving similar manifest-level changes to publishing configuration.

Suggested reviewers

cerebrl
ancheetah

Poem

🐰 A license in each pocket, so proper and fine,
Files configured cleanly, each package in line,
Build artifacts banished with a ! so grand,
The SDK hops forward, well-organized and planned! 📦✨

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title 'chore: fix-publish-dirs' accurately reflects the main change: fixing package publishing configuration by updating files arrays across multiple package.json files.
Description check	✅ Passed	The description is brief but complete, referencing the JIRA ticket and clearly stating the purpose. However, it lacks detail about what was changed and why.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch fix-publish-dirs

📝 Coding Plan

Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

nx-cloud · 2026-03-19T20:44:28Z

View your CI Pipeline Execution ↗ for commit b7987e6

Command	Status	Duration	Result
`nx run-many -t build --no-agents`	✅ Succeeded	1s	View ↗
`nx affected -t build lint test typecheck e2e-ci`	✅ Succeeded	1m 47s	View ↗

☁️ Nx Cloud last updated this comment at 2026-03-19 20:46:49 UTC

pkg-pr-new · 2026-03-19T20:46:59Z

Open in StackBlitz

@forgerock/davinci-client

pnpm add https://pkg.pr.new/ForgeRock/ping-javascript-sdk/@forgerock/davinci-client@552

@forgerock/device-client

pnpm add https://pkg.pr.new/ForgeRock/ping-javascript-sdk/@forgerock/device-client@552

@forgerock/journey-client

pnpm add https://pkg.pr.new/ForgeRock/ping-javascript-sdk/@forgerock/journey-client@552

@forgerock/oidc-client

pnpm add https://pkg.pr.new/ForgeRock/ping-javascript-sdk/@forgerock/oidc-client@552

@forgerock/protect

pnpm add https://pkg.pr.new/ForgeRock/ping-javascript-sdk/@forgerock/protect@552

@forgerock/sdk-types

pnpm add https://pkg.pr.new/ForgeRock/ping-javascript-sdk/@forgerock/sdk-types@552

@forgerock/sdk-utilities

pnpm add https://pkg.pr.new/ForgeRock/ping-javascript-sdk/@forgerock/sdk-utilities@552

@forgerock/iframe-manager

pnpm add https://pkg.pr.new/ForgeRock/ping-javascript-sdk/@forgerock/iframe-manager@552

@forgerock/sdk-logger

pnpm add https://pkg.pr.new/ForgeRock/ping-javascript-sdk/@forgerock/sdk-logger@552

@forgerock/sdk-oidc

pnpm add https://pkg.pr.new/ForgeRock/ping-javascript-sdk/@forgerock/sdk-oidc@552

@forgerock/sdk-request-middleware

pnpm add https://pkg.pr.new/ForgeRock/ping-javascript-sdk/@forgerock/sdk-request-middleware@552

@forgerock/storage

pnpm add https://pkg.pr.new/ForgeRock/ping-javascript-sdk/@forgerock/storage@552

commit: b7987e6

github-actions · 2026-03-19T20:47:27Z

Deployed 8c46c11 to https://ForgeRock.github.io/ping-javascript-sdk/pr-552/8c46c111ad374254de2d24346963b7975b762570 branch gh-pages in ForgeRock/ping-javascript-sdk

github-actions · 2026-03-19T20:47:33Z

📦 Bundle Size Analysis

🆕 New Packages

🆕 @forgerock/journey-client - 87.8 KB (new)
🆕 @forgerock/journey-client - 0.0 KB (new)

➖ No Changes

➖ @forgerock/sdk-logger - 1.6 KB
➖ @forgerock/sdk-request-middleware - 4.5 KB
➖ @forgerock/iframe-manager - 2.4 KB
➖ @forgerock/sdk-oidc - 4.8 KB
➖ @forgerock/storage - 1.5 KB
➖ @forgerock/sdk-types - 7.9 KB
➖ @forgerock/protect - 150.1 KB
➖ @forgerock/device-client - 9.2 KB
➖ @forgerock/davinci-client - 41.3 KB
➖ @forgerock/sdk-utilities - 11.2 KB
➖ @forgerock/oidc-client - 24.9 KB

13 packages analyzed • Baseline from latest main build

Legend

🆕 New package
🔺 Size increased
🔻 Size decreased
➖ No change

ℹ️ How bundle sizes are calculated

Current Size: Total gzipped size of all files in the package's dist directory
Baseline: Comparison against the latest build from the main branch
Files included: All build outputs except source maps and TypeScript build cache
Exclusions: .map, .tsbuildinfo, and .d.ts.map files

_{🔄 Updated automatically on each push to this PR}

codecov-commenter · 2026-03-19T21:16:55Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 14.77%. Comparing base (5d6747a) to head (b7987e6).
⚠️ Report is 8 commits behind head on main.

❌ Your project status has failed because the head coverage (14.77%) is below the target coverage (40.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files

@@             Coverage Diff             @@
##             main     #552       +/-   ##
===========================================
- Coverage   70.90%   14.77%   -56.14%     
===========================================
  Files          53      153      +100     
  Lines        2021    26262    +24241     
  Branches      377     1056      +679     
===========================================
+ Hits         1433     3879     +2446     
- Misses        588    22383    +21795

see 101 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

chore: fix-publish-dirs

b7987e6

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: fix-publish-dirs#552

chore: fix-publish-dirs#552
ryanbas21 wants to merge 1 commit intomainfrom
fix-publish-dirs

ryanbas21 commented Mar 19, 2026 •

edited by coderabbitai bot

Loading

Uh oh!

changeset-bot bot commented Mar 19, 2026

Uh oh!

coderabbitai bot commented Mar 19, 2026 •

edited

Loading

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested reviewers

Poem

Uh oh!

nx-cloud bot commented Mar 19, 2026 •

edited

Loading

Uh oh!

pkg-pr-new bot commented Mar 19, 2026

Uh oh!

github-actions bot commented Mar 19, 2026

Uh oh!

github-actions bot commented Mar 19, 2026

Uh oh!

codecov-commenter commented Mar 19, 2026

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

2 participants

Conversation

ryanbas21 commented Mar 19, 2026 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

JIRA Ticket

Description

Summary by CodeRabbit

Uh oh!

changeset-bot bot commented Mar 19, 2026

⚠️ No Changeset found

Uh oh!

coderabbitai bot commented Mar 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested reviewers

Poem

Uh oh!

nx-cloud bot commented Mar 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pkg-pr-new bot commented Mar 19, 2026

Uh oh!

github-actions bot commented Mar 19, 2026

Uh oh!

github-actions bot commented Mar 19, 2026

📦 Bundle Size Analysis

📦 Bundle Size Analysis

🆕 New Packages

Legend

Uh oh!

codecov-commenter commented Mar 19, 2026

Codecov Report

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

2 participants

ryanbas21 commented Mar 19, 2026 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Mar 19, 2026 •

edited

Loading

nx-cloud bot commented Mar 19, 2026 •

edited

Loading