SDKS-4716: Fix for Push Notification E2E test#168
Closed
vibhorgoswami wants to merge 1 commit intodevelopfrom
Closed
SDKS-4716: Fix for Push Notification E2E test#168vibhorgoswami wants to merge 1 commit intodevelopfrom
vibhorgoswami wants to merge 1 commit intodevelopfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #168 +/- ##
=============================================
- Coverage 44.92% 44.88% -0.04%
Complexity 1232 1232
=============================================
Files 302 302
Lines 9389 9401 +12
Branches 1352 1358 +6
=============================================
+ Hits 4218 4220 +2
- Misses 4630 4642 +12
+ Partials 541 539 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
witrisna
reviewed
Mar 5, 2026
| credentialId = notificationData["credentialId"]?.jsonPrimitive?.content ?: "", | ||
| credentialId = notificationData["credentialId"]?.jsonPrimitive?.content | ||
| ?: notificationData["mechanismUID"]?.jsonPrimitive?.content | ||
| ?: "", |
Contributor
There was a problem hiding this comment.
Looks like we try to get credentialId first, if not exist we get the mechanismUID, any reason for this scenario? Do you see the legacy set the id either in this 2 attributes?
Similar for other attributes mapping, we try to find if data exist on one attribute, if not found try another, not sure if this is correct.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA Ticket
SDKS-4716
Description
Fixes the PushNotification association with PushCredential. Enhance PushDeviceToken initialization with optional ID handling.
Testing