Use BigDecimal instead of Double in NumberFormat#82
Open
georgewfraser wants to merge 3 commits intoFasterXML:2.xfrom
Open
Use BigDecimal instead of Double in NumberFormat#82georgewfraser wants to merge 3 commits intoFasterXML:2.xfrom
georgewfraser wants to merge 3 commits intoFasterXML:2.xfrom
Conversation
Member
|
I can see why this could be an improvement, but it would also be a backwards-incompatible change, and possibly break existing code. Is there anything we could do to alleviate those problems? Otherwise simple upgrade of module to 2.7 (where this could be merged) could break existing deployments. |
Contributor
Author
|
We could have two functions like: private BigDecimal minimum;
public Double getMinimum() { ... }
@JsonIgnore
public BigDecimal getMinimumDecimal() { ... }This would avoid breaking existing code, at the cost of carrying a little bit of legacy cruft forever. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JSON can have number values outside the range of double. Also, it's important that multipleOf have an exact representation to be interpreted correctly. BigDecimal is better for these reasons.