Fix relative date unit calculation in admin.js#24
Open
g000m wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Fixes the “time ago” display in the admin UI by correcting how the appropriate relative-time unit (seconds/minutes/hours/…) is selected from the tokens map, addressing issue #21 where values were always shown in seconds.
Changes:
- Update
LHR.formatTimeSinceto select the largest matching time unit (instead of returning on the first match). - Compute
numberOfUnitsbased on the selected unit and format the final"X unit(s)"string.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
g000m
force-pushed
the
fix/relative-date-units
branch
from
9d2f7b0 to
0b219b8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes issues #21