MemoryOps: Drop MOPS handling into place for MemSet/MemCpy#5356
Merged
Sonicadvance1 merged 6 commits intoFEX-Emu:mainfrom Mar 20, 2026
Merged
MemoryOps: Drop MOPS handling into place for MemSet/MemCpy#5356Sonicadvance1 merged 6 commits intoFEX-Emu:mainfrom
Sonicadvance1 merged 6 commits intoFEX-Emu:mainfrom
Conversation
lioncash
force-pushed
the
mops
branch
2 times, most recently
from
9a4b5ae to
637bfd1
Compare
lioncash
changed the title
Can be further expanded to handle other optimization cases, but this kicks it off for forward direction memsets at least.
Lets us handle potential inline memset values. Also fixes up the STOS tests to actually ensure all values in the verification step pass.
With the MOPS featureset dropped in, we can also accelerate memcpy paths on hardware that supports it.
lioncash
force-pushed
the
mops
branch
2 times, most recently
from
1c32dfa to
8489b0b
Compare
Sonicadvance1
approved these changes
Mar 20, 2026
Member
Sonicadvance1
left a comment
Sonicadvance1
left a comment
There was a problem hiding this comment.
I do love that there is an enormous brickhouse of code after the memcpy overlap case. It's quite funny. Once we have hardware that we care about that supports MOPS then we can benchmark and see if it matters to move a helper to the dispatcher or something in that case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drops memset handling in first (and also makes some very old tests actually... test, instead of setting rcx to 0 and then doing nothing)