Merged
Conversation
12d3c58 to
fa551d1
Compare
Contributor
Author
|
@bryannielsen Hello, could you please check that PR. Is these tests are really necessary? |
Contributor
|
@Houdini it looks like the new Topics API that replaced FLoC still respects this header to "opt out of user tracking for interest-based advertising". The logic looks correct based on the docs but I see that a similar request was made to remove the header from the core which is where this particular code came from so I think we can move this forward. It looks like the Laravel 9 tests are failing because of an issue composer audit found. I think we can add the ignore rule for this because any security issues with Laravel 9 are a concern for the user but not our tests. |
Ignore composer audit issues when creating a Laravel project
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
==instead of!==