[NoQA] Add Gusto approval mode settings#89653
Open
ShridharGoel wants to merge 13 commits intoExpensify:mainfrom
Open
[NoQA] Add Gusto approval mode settings#89653ShridharGoel wants to merge 13 commits intoExpensify:mainfrom
ShridharGoel wants to merge 13 commits intoExpensify:mainfrom
Conversation
|
Hey, I noticed you changed If you want to automatically generate translations for other locales, an Expensify employee will have to:
Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running: npx ts-node ./scripts/generateTranslations.ts --helpTypically, you'd want to translate only what you changed by running |
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
ShridharGoel
changed the title
ShridharGoel
changed the title
melvin-bot
Bot
requested review from
shubham1206agra
and removed request for
a team
|
@shubham1206agra Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
melvin-bot
Bot
requested review from
JmillsExpensify
and removed request for
a team
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0299513468
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Contributor
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. 🚀 ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
Contributor
|
@yuwenmemon Please run polyglot parrot on this PR. Thanks. |
Comment on lines
+26
to
+28
| if (!policyID) { | ||
| return; | ||
| } |
Contributor
There was a problem hiding this comment.
@ShridharGoel NAB: But we don't need to check for undefined policies. Also, you can make the param policyID as string only.
Contributor
|
@Expensify/design Tagging here for design approval |
Contributor
|
@yuwenmemon Changing approval mode is not working from BE side {
"jsonCode": 200,
"requestID": "9f79a340eca674f6-DEL",
"onyxData": [
{
"key": "policy_097D01B921724B07",
"onyxMethod": "merge",
"value": {
"connections": {
"gusto": {
"config": {
"approvalMode": ""
}
}
}
}
}
],
"previousUpdateID": 13104054341,
"lastUpdateID": 13104062395
} |
Contributor
Author
That's known, @yuwenmemon has already handled it. Should be live soon. |
Contributor
Reviewer Checklist
Screenshots/VideosScreen.Recording.2026-05-06.at.10.46.13.PM.mov |
Contributor
🦜 Polyglot Parrot! 🦜Squawk! Looks like you added some shiny new English strings. Allow me to parrot them back to you in other tongues: View the translation diffdiff --git a/src/languages/de.ts b/src/languages/de.ts
index 3f0f6f16..25b54343 100644
--- a/src/languages/de.ts
+++ b/src/languages/de.ts
@@ -7031,24 +7031,15 @@ Fügen Sie weitere Ausgabelimits hinzu, um den Cashflow Ihres Unternehmens zu sc
approvalMode: 'Genehmigungsmodus',
finalApprover: 'Endgültige:r Genehmiger:in',
notSet: 'Nicht festgelegt',
- approvalModeDescription: 'Mitglieder und Vorgesetzte sind für die Synchronisierung mit Gusto eingerichtet.',
+ approvalModeDescription: 'Mitglieder und Manager sind für die Synchronisation mit Gusto eingerichtet.',
approvalModeWarningTitle: 'Genehmigungsmodus ändern?',
approvalModeWarningPrompt: (helpSiteURL: string) =>
- `Möchtest du den Genehmigungsmodus für diesen Arbeitsbereich wirklich ändern? Weitere Informationen zu den verschiedenen Gusto-gestützten Arbeitsablaufmodi findest du auf unserer <a href="${helpSiteURL}">Hilfeseite</a>.`,
+ `Möchten Sie den Genehmigungsmodus für diesen Workspace wirklich ändern? Erfahren Sie mehr über die verschiedenen Gusto-aktivierten Workflow-Modi auf unserer <a href="${helpSiteURL}">Hilfeseite</a>.`,
approvalModeWarningConfirm: 'Genehmigungsmodus ändern',
approvalModes: {
- basic: {
- label: 'Einfache Genehmigung',
- description: 'Alle Benutzer reichen bei einer einzelnen Person zur Bearbeitung und Genehmigung ein.',
- },
- manager: {
- label: 'Genehmigung durch Vorgesetzte',
- description: 'Mitarbeitende reichen Berichte bei ihrem in Gusto konfigurierten direkten Vorgesetzten ein.',
- },
- custom: {
- label: 'Benutzerdefinierte Genehmigung',
- description: 'Ich richte Genehmigungsworkflows manuell in Expensify ein.',
- },
+ basic: {label: 'Einfache Genehmigung', description: 'Alle Benutzer reichen zur Bearbeitung und Genehmigung bei einer einzigen Person ein.'},
+ manager: {label: 'Managergenehmigung', description: 'Mitarbeitende reichen Berichte bei ihrer in Gusto hinterlegten direkten Führungskraft ein.'},
+ custom: {label: 'Benutzerdefinierte Genehmigung', description: 'Ich richte Genehmigungs-Workflows in Expensify manuell ein.'},
},
connect: 'Verbinden',
connectionDescription: 'Verbinde Gusto, um Mitarbeitergenehmigungen mit deinem Workspace zu synchronisieren.',
diff --git a/src/languages/fr.ts b/src/languages/fr.ts
index be61d34e..f4173899 100644
--- a/src/languages/fr.ts
+++ b/src/languages/fr.ts
@@ -7054,23 +7054,14 @@ Ajoutez davantage de règles de dépenses pour protéger la trésorerie de l’e
finalApprover: 'Approbateur final',
notSet: 'Non défini',
approvalModeDescription: 'Les membres et les responsables sont configurés pour se synchroniser avec Gusto.',
- approvalModeWarningTitle: 'Modifier le mode d’approbation ?',
+ approvalModeWarningTitle: 'Changer le mode d’approbation ?',
approvalModeWarningPrompt: (helpSiteURL: string) =>
- `Voulez-vous vraiment modifier le mode d’approbation de cet espace de travail ? En savoir plus sur les différents modes de flux de travail compatibles avec Gusto sur notre <a href="${helpSiteURL}">site d’aide</a>.`,
+ `Êtes-vous sûr·e de vouloir modifier le mode d’approbation de cet espace de travail ? En savoir plus sur les différents modes de workflow compatibles avec Gusto sur notre <a href="${helpSiteURL}">site d’aide</a>.`,
approvalModeWarningConfirm: 'Modifier le mode d’approbation',
approvalModes: {
- basic: {
- label: 'Approbation simple',
- description: 'Tous les utilisateurs soumettent leurs rapports à une seule personne pour traitement et approbation.',
- },
- manager: {
- label: 'Approbation par responsable',
- description: 'Les employés soumettent leurs rapports à leur responsable direct configuré dans Gusto.',
- },
- custom: {
- label: 'Approbation personnalisée',
- description: 'Je configurerai manuellement les flux de travail d’approbation dans Expensify.',
- },
+ basic: {label: 'Approbation simple', description: 'Tous les utilisateurs soumettent à une seule personne pour traitement et approbation.'},
+ manager: {label: 'Approbation du responsable', description: 'Les employé·e·s soumettent leurs rapports à leur responsable direct configuré dans Gusto.'},
+ custom: {label: 'Approbation personnalisée', description: 'Je configurerai manuellement les circuits de validation dans Expensify.'},
},
connect: 'Connect',
connectionDescription: 'Connectez Gusto pour synchroniser les validations des employé·e·s avec votre espace de travail.',
diff --git a/src/languages/it.ts b/src/languages/it.ts
index 7857c2a3..bebaf863 100644
--- a/src/languages/it.ts
+++ b/src/languages/it.ts
@@ -7016,24 +7016,15 @@ Aggiungi altre regole di spesa per proteggere il flusso di cassa aziendale.`,
approvalMode: 'Modalità approvazione',
finalApprover: 'Approvazione finale',
notSet: 'Non impostato',
- approvalModeDescription: 'Membri e responsabili sono configurati per sincronizzarsi con Gusto.',
+ approvalModeDescription: 'I membri e i responsabili sono configurati per la sincronizzazione con Gusto.',
approvalModeWarningTitle: 'Cambiare modalità di approvazione?',
approvalModeWarningPrompt: (helpSiteURL: string) =>
- `Vuoi davvero cambiare la modalità di approvazione per questo spazio di lavoro? Scopri di più sulle diverse modalità di flusso di lavoro abilitate da Gusto nel nostro <a href="${helpSiteURL}">sito di assistenza</a>.`,
+ `Sei sicuro di voler cambiare la modalità di approvazione per questo spazio di lavoro? Scopri di più sulle diverse modalità di flusso di lavoro abilitate per Gusto nel nostro <a href="${helpSiteURL}">sito di assistenza</a>.`,
approvalModeWarningConfirm: 'Cambia modalità di approvazione',
approvalModes: {
- basic: {
- label: 'Approvazione di base',
- description: 'Tutti gli utenti inviano a una sola persona per l’elaborazione e l’approvazione.',
- },
- manager: {
- label: 'Approvazione del manager',
- description: 'I dipendenti inviano i report al proprio manager diretto configurato in Gusto.',
- },
- custom: {
- label: 'Approvazione personalizzata',
- description: 'Configurerò manualmente i flussi di lavoro di approvazione in Expensify.',
- },
+ basic: {label: 'Approvazione di base', description: 'Tutti gli utenti inviano a una singola persona per l’elaborazione e l’approvazione.'},
+ manager: {label: 'Approvazione del responsabile', description: 'I dipendenti inviano i report al proprio responsabile diretto configurato in Gusto.'},
+ custom: {label: 'Approvazione personalizzata', description: 'Imposterò manualmente i flussi di approvazione in Expensify.'},
},
connect: 'Collega',
connectionDescription: 'Collega Gusto per sincronizzare le approvazioni dei dipendenti con il tuo spazio di lavoro.',
diff --git a/src/languages/ja.ts b/src/languages/ja.ts
index 7afbf7d7..ceafe94e 100644
--- a/src/languages/ja.ts
+++ b/src/languages/ja.ts
@@ -6942,21 +6942,12 @@ ${reportName}
approvalModeDescription: 'メンバーとマネージャーは Gusto と同期するように設定されています。',
approvalModeWarningTitle: '承認モードを変更しますか？',
approvalModeWarningPrompt: (helpSiteURL: string) =>
- `このワークスペースの承認モードを変更してもよろしいですか？ Gusto 対応の各ワークフローモードについて詳しくは、<a href="${helpSiteURL}">ヘルプサイト</a>をご覧ください。`,
+ `このワークスペースの承認モードを変更してもよろしいですか？Gusto 対応の各ワークフローモードについては、<a href="${helpSiteURL}">ヘルプサイト</a>で詳しくご覧いただけます。`,
approvalModeWarningConfirm: '承認モードを変更',
approvalModes: {
- basic: {
- label: '基本承認',
- description: 'すべてのユーザーは、処理と承認のために1人の担当者に提出します。',
- },
- manager: {
- label: 'マネージャー承認',
- description: '従業員は、Gusto で設定された直属のマネージャーにレポートを提出します。',
- },
- custom: {
- label: 'カスタム承認',
- description: 'Expensify で承認ワークフローを手動で設定します。',
- },
+ basic: {label: '基本承認', description: 'すべてのユーザーは、処理と承認のために 1 人の担当者に提出します。'},
+ manager: {label: 'マネージャー承認', description: '従業員は、Gusto で設定された直属のマネージャーにレポートを提出します。'},
+ custom: {label: 'カスタム承認', description: 'Expensify で承認ワークフローを手動で設定します。'},
},
connect: '接続',
connectionDescription: 'Gusto を接続して、従業員の承認をワークスペースと同期させましょう。',
diff --git a/src/languages/nl.ts b/src/languages/nl.ts
index d3655cb1..b7301b1b 100644
--- a/src/languages/nl.ts
+++ b/src/languages/nl.ts
@@ -6995,24 +6995,15 @@ er bestedingsregels toe om de kasstroom van het bedrijf te beschermen.`,
approvalMode: 'Goedkeuringsmodus',
finalApprover: 'Laatste fiatteur',
notSet: 'Niet ingesteld',
- approvalModeDescription: 'Leden en managers zijn ingesteld om met Gusto te synchroniseren.',
+ approvalModeDescription: 'Leden en managers zijn ingesteld om te synchroniseren met Gusto.',
approvalModeWarningTitle: 'Goedkeuringsmodus wijzigen?',
approvalModeWarningPrompt: (helpSiteURL: string) =>
- `Weet je zeker dat je de goedkeuringsmodus voor deze werkruimte wilt wijzigen? Lees meer over de verschillende Gusto-werkstroommodi op onze <a href="${helpSiteURL}">helpsite</a>.`,
+ `Weet je zeker dat je de goedkeuringsmodus voor deze werkruimte wilt wijzigen? Lees meer over de verschillende Gusto-ondersteunde workflowmodi op onze <a href="${helpSiteURL}">help-site</a>.`,
approvalModeWarningConfirm: 'Goedkeuringsmodus wijzigen',
approvalModes: {
- basic: {
- label: 'Basisgoedkeuring',
- description: 'Alle gebruikers dienen in bij één persoon voor verwerking en goedkeuring.',
- },
- manager: {
- label: 'Goedkeuring door manager',
- description: 'Medewerkers dienen rapporten in bij hun directe manager die in Gusto is geconfigureerd.',
- },
- custom: {
- label: 'Aangepaste goedkeuring',
- description: 'Ik stel goedkeuringswerkstromen handmatig in Expensify in.',
- },
+ basic: {label: 'Basisgoedkeuring', description: 'Alle gebruikers dienen bij één persoon in voor verwerking en goedkeuring.'},
+ manager: {label: 'Goedkeuring manager', description: 'Werknemers dienen rapporten in bij hun direct leidinggevende die is ingesteld in Gusto.'},
+ custom: {label: 'Aangepaste goedkeuring', description: 'Ik stel goedkeuringsworkflows handmatig in in Expensify.'},
},
connect: 'Verbinden',
connectionDescription: 'Verbind Gusto om goedkeuringen van werknemers gesynchroniseerd te houden met je workspace.',
diff --git a/src/languages/pl.ts b/src/languages/pl.ts
index 87b45349..9359cab9 100644
--- a/src/languages/pl.ts
+++ b/src/languages/pl.ts
@@ -6991,21 +6991,12 @@ Dodaj więcej zasad wydatków, żeby chronić płynność finansową firmy.`,
approvalModeDescription: 'Członkowie i menedżerowie są skonfigurowani do synchronizacji z Gusto.',
approvalModeWarningTitle: 'Zmienić tryb zatwierdzania?',
approvalModeWarningPrompt: (helpSiteURL: string) =>
- `Czy na pewno chcesz zmienić tryb zatwierdzania dla tej przestrzeni roboczej? Dowiedz się więcej o różnych trybach przepływu pracy obsługiwanych przez Gusto w naszej <a href="${helpSiteURL}">witrynie pomocy</a>.`,
+ `Czy na pewno chcesz zmienić tryb zatwierdzania dla tego obszaru roboczego? Dowiedz się więcej o różnych trybach przepływu pracy obsługiwanych przez Gusto w naszej <a href="${helpSiteURL}">witrynie pomocy</a>.`,
approvalModeWarningConfirm: 'Zmień tryb zatwierdzania',
approvalModes: {
- basic: {
- label: 'Podstawowe zatwierdzanie',
- description: 'Wszyscy użytkownicy przesyłają do jednej osoby do przetworzenia i zatwierdzenia.',
- },
- manager: {
- label: 'Zatwierdzanie przez menedżera',
- description: 'Pracownicy przesyłają raporty do swojego bezpośredniego menedżera skonfigurowanego w Gusto.',
- },
- custom: {
- label: 'Niestandardowe zatwierdzanie',
- description: 'Ręcznie skonfiguruję procesy zatwierdzania w Expensify.',
- },
+ basic: {label: 'Podstawowa akceptacja', description: 'Wszyscy użytkownicy przesyłają wydatki do jednej osoby w celu ich przetworzenia i zatwierdzenia.'},
+ manager: {label: 'Zatwierdzenie przez menedżera', description: 'Pracownicy przesyłają raporty do swojego bezpośredniego menedżera skonfigurowanego w Gusto.'},
+ custom: {label: 'Niestandardowa akceptacja', description: 'Ręcznie skonfiguruję procesy zatwierdzania w Expensify.'},
},
connect: 'Połącz',
connectionDescription: 'Połącz Gusto, aby synchronizować akceptacje pracowników z Twoim miejscem pracy.',
diff --git a/src/languages/pt-BR.ts b/src/languages/pt-BR.ts
index 29d884ae..5da3a7a1 100644
--- a/src/languages/pt-BR.ts
+++ b/src/languages/pt-BR.ts
@@ -6997,21 +6997,12 @@ Adicione mais regras de gasto para proteger o fluxo de caixa da empresa.`,
approvalModeDescription: 'Membros e gerentes estão configurados para sincronizar com o Gusto.',
approvalModeWarningTitle: 'Alterar modo de aprovação?',
approvalModeWarningPrompt: (helpSiteURL: string) =>
- `Tem certeza de que deseja alterar o modo de aprovação deste espaço de trabalho? Saiba mais sobre os diferentes modos de fluxo de trabalho habilitados pelo Gusto em nosso <a href="${helpSiteURL}">site de ajuda</a>.`,
+ `Tem certeza de que deseja alterar o modo de aprovação deste workspace? Saiba mais sobre os diferentes modos de fluxo de trabalho com Gusto em nosso <a href="${helpSiteURL}">site de ajuda</a>.`,
approvalModeWarningConfirm: 'Alterar modo de aprovação',
approvalModes: {
- basic: {
- label: 'Aprovação básica',
- description: 'Todos os usuários enviam para uma única pessoa para processamento e aprovação.',
- },
- manager: {
- label: 'Aprovação do gerente',
- description: 'Os funcionários enviam relatórios para o gerente direto configurado no Gusto.',
- },
- custom: {
- label: 'Aprovação personalizada',
- description: 'Vou configurar manualmente os fluxos de trabalho de aprovação no Expensify.',
- },
+ basic: {label: 'Aprovação básica', description: 'Todos os usuários enviam para uma única pessoa para processamento e aprovação.'},
+ manager: {label: 'Aprovação do gerente', description: 'Os funcionários enviam relatórios ao gestor direto configurado no Gusto.'},
+ custom: {label: 'Aprovação personalizada', description: 'Vou configurar manualmente os fluxos de aprovação no Expensify.'},
},
connect: 'Conectar',
connectionDescription: 'Conecte o Gusto para manter as aprovações de funcionários sincronizadas com seu workspace.',
diff --git a/src/languages/zh-hans.ts b/src/languages/zh-hans.ts
index 2b64aa7e..c267cc73 100644
--- a/src/languages/zh-hans.ts
+++ b/src/languages/zh-hans.ts
@@ -6821,24 +6821,15 @@ ${reportName}
approvalMode: '审批模式',
finalApprover: '最终审批人',
notSet: '未设置',
- approvalModeDescription: '成员和经理已设置为与 Gusto 同步。',
+ approvalModeDescription: '成员和管理员已设置为与 Gusto 同步。',
approvalModeWarningTitle: '更改审批模式？',
approvalModeWarningPrompt: (helpSiteURL: string) =>
- `你确定要更改此工作区的审批模式吗？请在我们的<a href="${helpSiteURL}">帮助网站</a>中了解更多关于不同 Gusto 启用工作流模式的信息。`,
+ `您确定要更改此工作区的审批模式吗？在我们的<a href="${helpSiteURL}">帮助网站</a>中了解更多关于不同 Gusto 启用的工作流模式的信息。`,
approvalModeWarningConfirm: '更改审批模式',
approvalModes: {
- basic: {
- label: '基本审批',
- description: '所有用户都提交给同一个人进行处理和审批。',
- },
- manager: {
- label: '经理审批',
- description: '员工将报告提交给 Gusto 中配置的直属经理。',
- },
- custom: {
- label: '自定义审批',
- description: '我将在 Expensify 中手动设置审批工作流。',
- },
+ basic: {label: '基础审批', description: '所有用户都提交给同一个人进行处理和审批。'},
+ manager: {label: '经理审批', description: '员工会将报销单提交给在 Gusto 中配置的直属经理。'},
+ custom: {label: '自定义审批', description: '我将在 Expensify 中手动设置审批工作流程。'},
},
connect: '连接',
connectionDescription: '连接 Gusto，以在您的工作区中同步员工审批。',
Note You can apply these changes to your branch by copying the patch to your clipboard, then running |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Adds the Gusto approval mode settings for the HR workspace page.
Fixed Issues
$ #87013
PROPOSAL:
Tests
gustoNewDot).Offline tests
QA Steps
Same as tests.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2026-05-06.at.9.24.02.AM.mov
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Screen.Recording.2026-05-06.at.9.25.11.AM.mov