[CP Staging] fix Web - Tab name persists as "Settings - Profile" after opening Workspaces tab

src/libs/UnreadIndicatorUpdater/updateUnread/index.android.ts

@@ -3,8 +3,4 @@ import type UpdateUnread from './types';
 // Android does not yet implement this
 const updateUnread: UpdateUnread = () => {};
 
-// Page title management is not applicable on native platforms
-const setPageTitle = () => {};
-
 export default updateUnread;
-export {setPageTitle};

src/libs/UnreadIndicatorUpdater/updateUnread/index.ios.ts

@@ -9,8 +9,4 @@ const updateUnread: UpdateUnread = (totalCount) => {
     Airship.push.iOS.setBadgeNumber(totalCount);
 };
 
-// Page title management is not applicable on native platforms
-const setPageTitle = () => {};
-
 export default updateUnread;
-export {setPageTitle};

src/libs/UnreadIndicatorUpdater/updateUnread/index.ts

@@ -5,52 +5,28 @@ import CONFIG from '@src/CONFIG';
 import type UpdateUnread from './types';
 
 let unreadTotalCount = 0;
-let currentPageTitle = '';
-
-/**
- * Set the current page-specific title (called by useDocumentTitle hook)
- * @param title - The page-specific title
- */
-function setPageTitle(title: string) {
-    currentPageTitle = title;
-    // Immediately update the document title when page title changes
-    updateDocumentTitle();
-}
-
 /**
- * Update the actual document title and favicon
+ * Set the page title on web
  */
-function updateDocumentTitle() {
-    const hasUnread = unreadTotalCount !== 0;
+const updateUnread: UpdateUnread = (totalCount) => {
+    const hasUnread = totalCount !== 0;
+    unreadTotalCount = totalCount;
     // This setTimeout is required because due to how react rendering messes with the DOM, the document title can't be modified synchronously, and we must wait until all JS is done
     // running before setting the title.
     setTimeout(() => {
         // There is a Chrome browser bug that causes the title to revert back to the previous when we are navigating back. Setting the title to an empty string
         // seems to improve this issue.
         document.title = '';
-
-        // Use page-specific title if available, otherwise use the default SITE_TITLE
-        const baseTitle = currentPageTitle || CONFIG.SITE_TITLE;
-        document.title = hasUnread ? `(${unreadTotalCount}) ${baseTitle}` : baseTitle;
-
+        document.title = hasUnread ? `(${totalCount}) ${CONFIG.SITE_TITLE}` : CONFIG.SITE_TITLE;
         const favicon = document.getElementById('favicon');
         if (favicon instanceof HTMLLinkElement) {
             favicon.href = hasUnread ? CONFIG.FAVICON.UNREAD : CONFIG.FAVICON.DEFAULT;
         }
     }, 0);
-}
-
-/**
- * Set the page title on web
- */
-const updateUnread: UpdateUnread = (totalCount) => {
-    unreadTotalCount = totalCount;
-    updateDocumentTitle();
 };
 
 window.addEventListener('popstate', () => {
     updateUnread(unreadTotalCount);
 });
 
 export default updateUnread;
-export {setPageTitle};

src/pages/TeachersUnite/SaveTheWorldPage.tsx

@@ -5,7 +5,6 @@ import MenuItemList from '@components/MenuItemList';
 import ScreenWrapper from '@components/ScreenWrapper';
 import ScrollView from '@components/ScrollView';
 import Section from '@components/Section';
-import useDocumentTitle from '@hooks/useDocumentTitle';
 import {useMemoizedLazyIllustrations} from '@hooks/useLazyAsset';
 import useLocalize from '@hooks/useLocalize';
 import useResponsiveLayout from '@hooks/useResponsiveLayout';
@@ -27,8 +26,6 @@ function SaveTheWorldPage() {
     const theme = useTheme();
     const illustrations = useMemoizedLazyIllustrations(['TeachersUnite']);
     const saveTheWorldIllustration = useSaveTheWorldSectionIllustration();
-    useDocumentTitle(`${translate('common.settings')} - ${translate('sidebarScreen.saveTheWorld')}`);
-
     const menuItems = useMemo(() => {
         const baseMenuItems = [
             {

src/pages/settings/AboutPage/AboutPage.tsx

@@ -10,7 +10,6 @@ import ScreenWrapper from '@components/ScreenWrapper';
 import ScrollView from '@components/ScrollView';
 import Section from '@components/Section';
 import Text from '@components/Text';
-import useDocumentTitle from '@hooks/useDocumentTitle';
 import {useMemoizedLazyExpensifyIcons, useMemoizedLazyIllustrations} from '@hooks/useLazyAsset';
 import useLocalize from '@hooks/useLocalize';
 import useOnyx from '@hooks/useOnyx';
@@ -62,7 +61,6 @@ function AboutPage() {
     const {shouldUseNarrowLayout} = useResponsiveLayout();
     const aboutIllustration = useAboutSectionIllustration();
     const [conciergeReportID] = useOnyx(ONYXKEYS.CONCIERGE_REPORT_ID);
-    useDocumentTitle(`${translate('common.settings')} - ${translate('initialSettingsPage.about')}`);
 
     const menuItems = useMemo(() => {
         const baseMenuItems: MenuItem[] = [

src/pages/settings/Preferences/PreferencesPage.tsx

@@ -8,7 +8,6 @@ import Section from '@components/Section';
 import Switch from '@components/Switch';
 import Text from '@components/Text';
 import {useCurrencyListActions} from '@hooks/useCurrencyList';
-import useDocumentTitle from '@hooks/useDocumentTitle';
 import {useMemoizedLazyIllustrations} from '@hooks/useLazyAsset';
 import useLocalize from '@hooks/useLocalize';
 import useOnyx from '@hooks/useOnyx';
@@ -48,7 +47,6 @@ function PreferencesPage() {
     const styles = useThemeStyles();
     const {translate} = useLocalize();
     const {shouldUseNarrowLayout} = useResponsiveLayout();
-    useDocumentTitle(`${translate('common.settings')} - ${translate('common.preferences')}`);
 
     return (
         <ScreenWrapper

src/pages/settings/Profile/ProfilePage.tsx

@@ -15,7 +15,6 @@ import ScreenWrapper from '@components/ScreenWrapper';
 import ScrollView from '@components/ScrollView';
 import Section from '@components/Section';
 import useCurrentUserPersonalDetails from '@hooks/useCurrentUserPersonalDetails';
-import useDocumentTitle from '@hooks/useDocumentTitle';
 import {useMemoizedLazyAsset, useMemoizedLazyExpensifyIcons} from '@hooks/useLazyAsset';
 import useLocalize from '@hooks/useLocalize';
 import useOnyx from '@hooks/useOnyx';
@@ -71,8 +70,6 @@ function ProfilePage() {
     const [vacationDelegate] = useOnyx(ONYXKEYS.NVP_PRIVATE_VACATION_DELEGATE);
     const {isActingAsDelegate} = useDelegateNoAccessState();
     const {showDelegateNoAccessModal} = useDelegateNoAccessActions();
-    useDocumentTitle(`${translate('common.settings')} - ${translate('common.profile')}`);
-
     const publicOptions = [
         {
             description: translate('displayNamePage.headerTitle'),

src/pages/settings/Rules/ExpenseRulesPage.tsx

@@ -18,7 +18,6 @@ import CustomListHeader from '@components/SelectionListWithModal/CustomListHeade
 import TableListItemSkeleton from '@components/Skeletons/TableRowSkeleton';
 import Text from '@components/Text';
 import useAutoTurnSelectionModeOffWhenHasNoActiveOption from '@hooks/useAutoTurnSelectionModeOffWhenHasNoActiveOption';
-import useDocumentTitle from '@hooks/useDocumentTitle';
 import {useMemoizedLazyExpensifyIcons, useMemoizedLazyIllustrations} from '@hooks/useLazyAsset';
 import useLocalize from '@hooks/useLocalize';
 import useMobileSelectionMode from '@hooks/useMobileSelectionMode';
@@ -55,7 +54,6 @@ function ExpenseRulesPage() {
     const [selectedRules, setSelectedRules] = useState<string[]>([]);
     const [deleteConfirmModalVisible, setDeleteConfirmModalVisible] = useState(false);
     const styles = useThemeStyles();
-    useDocumentTitle(`${translate('common.settings')} - ${translate('expenseRulesPage.title')}`);
 
     useEffect(() => {
         // Clear selection when rule is changed as hash is outdated

src/pages/settings/Security/SecuritySettingsPage.tsx

@@ -19,7 +19,6 @@ import Section from '@components/Section';
 import Text from '@components/Text';
 import TextLink from '@components/TextLink';
 import useCurrentUserPersonalDetails from '@hooks/useCurrentUserPersonalDetails';
-import useDocumentTitle from '@hooks/useDocumentTitle';
 import {useMemoizedLazyExpensifyIcons, useMemoizedLazyIllustrations} from '@hooks/useLazyAsset';
 import useLocalize from '@hooks/useLocalize';
 import useOnyx from '@hooks/useOnyx';
@@ -106,7 +105,6 @@ function SecuritySettingsPage() {
     const hasDelegators = delegators.length > 0;
 
     const hasEverRegisteredForMultifactorAuthentication = account?.multifactorAuthenticationPublicKeyIDs !== CONST.MULTIFACTOR_AUTHENTICATION.PUBLIC_KEYS_AUTHENTICATION_NEVER_REGISTERED;
-    useDocumentTitle(`${translate('common.settings')} - ${translate('initialSettingsPage.security')}`);
 
     const setMenuPosition = useCallback(() => {
         if (!delegateButtonRef.current) {

src/pages/settings/Subscription/SubscriptionSettingsPage.tsx

@@ -4,7 +4,6 @@ import FullScreenLoadingIndicator from '@components/FullscreenLoadingIndicator';
 import HeaderWithBackButton from '@components/HeaderWithBackButton';
 import ScreenWrapper from '@components/ScreenWrapper';
 import ScrollView from '@components/ScrollView';
-import useDocumentTitle from '@hooks/useDocumentTitle';
 import {useMemoizedLazyIllustrations} from '@hooks/useLazyAsset';
 import useLocalize from '@hooks/useLocalize';
 import useOnyx from '@hooks/useOnyx';
@@ -29,8 +28,6 @@ function SubscriptionSettingsPage({route}: SubscriptionSettingsPageProps) {
     const styles = useThemeStyles();
     const subscriptionPlan = useSubscriptionPlan();
     const illustrations = useMemoizedLazyIllustrations(['CreditCardsNew']);
-    useDocumentTitle(`${translate('common.settings')} - ${translate('workspace.common.subscription')}`);
-
     useEffect(() => {
         openSubscriptionPage();
     }, []);

src/pages/settings/Troubleshoot/TroubleshootPage.tsx

@@ -16,7 +16,6 @@ import SentryDebugToolMenu from '@components/SentryDebugToolMenu';
 import Switch from '@components/Switch';
 import TestToolMenu from '@components/TestToolMenu';
 import TestToolRow from '@components/TestToolRow';
-import useDocumentTitle from '@hooks/useDocumentTitle';
 import useEnvironment from '@hooks/useEnvironment';
 import {useMemoizedLazyExpensifyIcons, useMemoizedLazyIllustrations} from '@hooks/useLazyAsset';
 import useLocalize from '@hooks/useLocalize';
@@ -64,7 +63,6 @@ function TroubleshootPage() {
     const [tryNewDot] = useOnyx(ONYXKEYS.NVP_TRY_NEW_DOT);
     const shouldOpenSurveyReasonPage = tryNewDot?.classicRedirect?.dismissed === false;
     const {setShouldResetSearchQuery} = useSearchActionsContext();
-    useDocumentTitle(`${translate('common.settings')} - ${translate('initialSettingsPage.aboutPage.troubleshoot')}`);
     const exportOnyxState = useCallback(() => {
         ExportOnyxState.readFromOnyxDatabase().then((value: Record<string, unknown>) => {
             const dataToShare = ExportOnyxState.maskOnyxState(value, shouldMaskOnyxState);

src/pages/settings/Wallet/WalletPage/index.tsx

@@ -22,7 +22,6 @@ import Section from '@components/Section';
 import Text from '@components/Text';
 import useConfirmModal from '@hooks/useConfirmModal';
 import useCurrentUserPersonalDetails from '@hooks/useCurrentUserPersonalDetails';
-import useDocumentTitle from '@hooks/useDocumentTitle';
 import {useMemoizedLazyExpensifyIcons, useMemoizedLazyIllustrations} from '@hooks/useLazyAsset';
 import useLocalize from '@hooks/useLocalize';
 import useNetwork from '@hooks/useNetwork';
@@ -107,7 +106,6 @@ function WalletPage() {
     const isPendingOnfidoResult = userWallet?.isPendingOnfidoResult ?? false;
     const hasFailedOnfido = userWallet?.hasFailedOnfido ?? false;
     const hasEligibleActiveAdmin = hasEligibleActiveAdminFromWorkspaces(allPolicies, currentUserLogin, paymentMethod?.selectedPaymentMethod?.bankAccountID?.toString());
-    useDocumentTitle(`${translate('common.settings')} - ${translate('common.wallet')}`);
 
     const updateShouldShowLoadingSpinner = useCallback(() => {
         // In order to prevent a loop, only update state of the spinner if there is a change