Follow up improvements for inline code blocks on native devices#79815
Closed
QichenZhu wants to merge 10000 commits intoExpensify:mainfrom
Closed
Follow up improvements for inline code blocks on native devices#79815QichenZhu wants to merge 10000 commits intoExpensify:mainfrom
inline code blocks on native devices#79815QichenZhu wants to merge 10000 commits intoExpensify:mainfrom
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
This implements step 1 on iOS of the 3-step incremental approach:
Fixed Issues
$ #57556
PROPOSAL:
Tests
Note: This change only affects iOS Native.
Offline tests
Same as Tests.
QA Steps
Same as Tests.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native (N/A)
Android: mWeb Chrome (N/A)
iOS: Native
iOS: mWeb Safari (N/A)
MacOS: Chrome / Safari (N/A)