Skip to content

Fix for dual numbers #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Expander wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Fix for dual numbers #41

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
42d5d93
adding failing test, see issue #40
Expander Mar 22, 2026
bb9df04
test for approximate equality
Expander Mar 22, 2026
4d82c05
match complex types for _li2 and li2_approx
Expander Mar 22, 2026
36e3203
adding comments
Expander Mar 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/Li2.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,7 +237,8 @@ li2(z::Real) = li2(Complex(z))

_li2(z::ComplexF16) = oftype(z, _li2(ComplexF32(z)))

function _li2(z::Complex{T})::Complex{T} where T
# overload for complex types for which li2_approx uses pre-computed Bernoulli numbers
function _li2(z::Complex{T})::Complex{T} where {T<:Union{Float32, Float64}}
rz, iz = reim(z)

if iszero(iz)
Expand Down Expand Up @@ -270,7 +271,8 @@ function _li2(z::Complex{T})::Complex{T} where T
end
end

function _li2(z::Complex{BigFloat})::Complex{BigFloat}
# overload for generic complex types
function _li2(z::Complex{T})::Complex{T} where T
rz, iz = reim(z)

if iszero(iz)
Expand Down
14 changes: 14 additions & 0 deletions test/Dual.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
if isdefined(Base, :get_extension)
import ForwardDiff

function li_dual(n::Integer, z::Complex)
z_dual = complex(ForwardDiff.Dual(real(z)), ForwardDiff.Dual(imag(z)))
PolyLog.li(n, z_dual)
end


@testset "Dual" begin
z = 0.5 + 0.8im
@test li_dual(2, z) ≈ PolyLog.li(2, z) rtol=1e-15
end
end
1 change: 1 addition & 0 deletions test/runtests.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ include("TestPrecision.jl")
include("DataReader.jl")
include("DataTester.jl")
include("Digamma.jl")
include("Dual.jl")
include("Eta.jl")
include("Factorial.jl")
include("Harmonic.jl")
Expand Down
Loading