Skip to content

refactor events#1059

Merged
maddie480 merged 6 commits intoEverestAPI:devfrom
microlith57:rework-events
Mar 17, 2026
Merged

refactor events#1059
maddie480 merged 6 commits intoEverestAPI:devfrom
microlith57:rework-events

Conversation

@microlith57
Copy link
Member

@microlith57 microlith57 commented Jan 4, 2026 •
edited
Loading

  • split Events into a partial class, split amongst the relevant classes
  • add some more events

testmod build: microlith57/CelesteTestMod#1 (check inside the workflow run)

@microlith57 microlith57 added the 0: draft This PR is not ready for review yet (bot-managed) label Jan 4, 2026
@microlith57 microlith57 mentioned this pull request Jan 8, 2026
Closed
@microlith57 microlith57 marked this pull request as ready for review January 8, 2026 06:17
@microlith57 microlith57 added 1: review needed This PR needs 2 approvals to be merged (bot-managed) and removed 0: draft This PR is not ready for review yet (bot-managed) labels Jan 8, 2026
@JaThePlayer
Copy link
Member

JaThePlayer commented Jan 15, 2026

Can you provide a list of all the new events? All the diffs from moving existing events around are making it hard to find them.

@microlith57
Copy link
Member Author

microlith57 commented Jan 31, 2026

@JaThePlayer please see the commit list; i split the commits per event.
the new events are Player.OnPauseInGBJ, Level.OnEnd, and Atlas.OnGetCustomFallback.

@microlith57 @aonkeeper4
add event for scene transitions
49dba9e 
Co-authored-by: aonkeeper4 <aonkeeper4@gmail.com>
@microlith57
Copy link
Member Author

microlith57 commented Feb 11, 2026

added a new event Celeste.OnSceneTransition, courtesy of @aonkeeper4

Wartori54
Wartori54 approved these changes Mar 14, 2026
View reviewed changes
Copy link
Member

@Wartori54 Wartori54 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. But lets hope no one ilhooked OnSceneTransition recently. (The ilhookviewer claims there werent any on April last year.)

@maddie480-bot
Copy link
Member

maddie480-bot commented Mar 14, 2026

The pull request was approved and entered the 3-day last-call window.
If no further reviews happen, it will end on Mar 17, 2026, 12:46 PM UTC, after which the pull request will be able to be merged.

@maddie480-bot maddie480-bot added 3: last call window This PR was approved, and is in the 5-day last-call window before getting merged (bot-managed) and removed 1: review needed This PR needs 2 approvals to be merged (bot-managed) labels Mar 14, 2026
@microlith57 microlith57 mentioned this pull request Mar 15, 2026
Open
@maddie480-bot
Copy link
Member

maddie480-bot commented Mar 17, 2026

The last-call window for this pull request ended. It can now be merged if no blockers were brought up.

@maddie480-bot maddie480-bot added 4: ready to merge This PR was approved and the last-call window is over (bot-managed) and removed 3: last call window This PR was approved, and is in the 5-day last-call window before getting merged (bot-managed) labels Mar 17, 2026
@maddie480 maddie480 merged commit bb4a9ee into EverestAPI:dev Mar 17, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Wartori54 Wartori54 Wartori54 approved these changes

@JaThePlayer JaThePlayer JaThePlayer approved these changes

Assignees

No one assigned

Labels

4: ready to merge This PR was approved and the last-call window is over (bot-managed)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@microlith57 @JaThePlayer @maddie480-bot @Wartori54 @maddie480