Implement smooth scrolling in OuiMainMenu#1049
Open
DashingCat wants to merge 1 commit intoEverestAPI:devfrom
Open
Implement smooth scrolling in OuiMainMenu#1049DashingCat wants to merge 1 commit intoEverestAPI:devfrom
DashingCat wants to merge 1 commit intoEverestAPI:devfrom
Conversation
maddie480-bot
added
the
1: review needed
DashingCat
force-pushed
the
implement-smooth-scrolling-in-ouimainmenu
branch
from
baf9f7c to
08484cd
Compare
Wartori54
reviewed
Mar 14, 2026
Member
Wartori54
left a comment
Wartori54
left a comment
There was a problem hiding this comment.
LGTM, havent tested yet though.
Small nitpick: point out in a comment where that smoothing constant comes from.
DashingCat
force-pushed
the
implement-smooth-scrolling-in-ouimainmenu
branch
2 times, most recently
from
94ad1c8 to
0255acd
Compare
Contributor
Author
|
Thanks @Wartori54 for the review, I edited the smoothing constant to Because this constant is already used elsewhere in Everest and in vanilla, I don't think it needs a comment, please let me know if I should add one. |
DashingCat
force-pushed
the
implement-smooth-scrolling-in-ouimainmenu
branch
from
0255acd to
8aa192b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up on #880 (review), this PR implements a smooth scrolling for buttons in the
OuiMainMenu.