Build: Set FMLModType depending on which ModLauncher version is used#104
Open
caoimhebyrne wants to merge 1 commit intomasterfrom
Open
Build: Set FMLModType depending on which ModLauncher version is used#104caoimhebyrne wants to merge 1 commit intomasterfrom
FMLModType depending on which ModLauncher version is used#104caoimhebyrne wants to merge 1 commit intomasterfrom
Conversation
This attribute was previously set to `LIBRARY` before 0696479 where it was removed for the following reason: > however since we require shading and relocation on ML9 anyway, we may as well just remove it outright. This is fine for production, but relocation does not apply in development environments. The type should be declared as `GAMELIBRARY` on >=ML9, and `LIBRARY` on <=ML8. Anything which uses UniversalCraft should also be on the `GAME` layer, and cannot be on any other layer (e.g. PLUGIN) as it will not be able to access UniversalCraft classes. If we want other libraries to be usable in development environments (Vigilance, Elementa), we'll have to ship separate artifacts of those for >=ML9 and <=ML8 with the `FMLModType` attribute set accordingly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This attribute was previously set to
LIBRARYbefore 0696479 where it was removed for the following reason:This is fine for production, but relocation does not apply in development environments. The type should be declared as
GAMELIBRARYon >=ML9, andLIBRARYon <=ML8.Anything which uses UniversalCraft should also be on the
GAMElayer, and cannot be on any other layer (e.g.PLUGIN) as it will not be able to access UniversalCraft classes. This includes our other libraries (UniversalCraft, Elementa). If we want those to also be usable in development environments, we'll have to ship separate artifacts of those for >=ML9 and <=ML8 with theFMLModTypeattribute set accordingly 😢.This PR might be a change that needs some more discussion, and we might want to hold off on it until we decide what to do with our other libraries (although, it probably makes sense to do either way).
Related to: #70, #73.