Skip to content

Correct values for collision and offroad rewards randomization#323

Merged
riccardosavorgnan merged 2 commits into3.0_betafrom
ricky/change_parameters
Mar 2, 2026
Merged

Correct values for collision and offroad rewards randomization#323
riccardosavorgnan merged 2 commits into3.0_betafrom
ricky/change_parameters

Conversation

@riccardosavorgnan
Copy link
Collaborator

No description provided.

@greptile-apps
Copy link

greptile-apps bot commented Mar 2, 2026

Greptile Summary

Fixed reward randomization bounds for reward_bound_collision_max and reward_bound_offroad_max from -2.9 to -0.1, expanding the randomization range from 0.1 to 2.9 for meaningful reward conditioning.

  • Collision reward bounds now properly randomize from -3.0 (severe penalty) to -0.1 (minimal penalty)
  • Offroad reward bounds now properly randomize from -3.0 (severe penalty) to -0.1 (minimal penalty)
  • Training timesteps increased from 2B to 5B (not mentioned in PR title)

Confidence Score: 4/5

  • This PR is safe to merge with the reward randomization fix being correct and well-justified
  • The reward bounds correction is sound - expanding from a negligible 0.1 range to a meaningful 2.9 range enables proper reward conditioning. Minor point deducted for undocumented total_timesteps increase, though this doesn't introduce bugs
  • No files require special attention

Important Files Changed

Filename Overview
pufferlib/config/ocean/drive.ini Corrected reward randomization bounds for collision/offroad from narrow range (0.1) to meaningful range (2.9); also increased total_timesteps from 2B to 5B

Last reviewed commit: 084327d

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 file reviewed, no comments

Edit Code Review Agent Settings | Greptile

@riccardosavorgnan riccardosavorgnan merged commit 0de3af3 into 3.0_beta Mar 2, 2026
10 checks passed
@riccardosavorgnan riccardosavorgnan deleted the ricky/change_parameters branch March 2, 2026 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants