Disable autocorrect by default in text inputs#5953
Merged
Conversation
4689c0b to
589a87f
Compare
swansontec
requested changes
Feb 20, 2026
Contributor
swansontec
left a comment
There was a problem hiding this comment.
Only tiny changes needed.
e932887 to
00c2957
Compare
Contributor
Author
|
Both comments addressed: used cleaners for error matching and instanceof for safe message extraction. |
swansontec
approved these changes
Feb 21, 2026
Contributor
swansontec
left a comment
There was a problem hiding this comment.
Approved, except the last commit. That one is wrong - we want to graduate files even if they have benign warnings.
00c2957 to
4dda380
Compare
Change SimpleTextInput and FilledTextInput to default autoCorrect to false
instead of true. This prevents automatic acceptance of autocorrect
suggestions when users interact with search bars and other text inputs.
LogsModal explicitly sets autoCorrect={true} to preserve autocorrect for
user message composition.
4dda380 to
0275afd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
None
Description
Context
Asana: "Desktop: Search bar automatically accepts autocorrects" (P2). On macOS and iPad, search bars would automatically accept autocorrect suggestions without explicit user action (e.g., typing "omw" would trigger "On my way!").
Changes
autoCorrecttofalseinSimpleTextInputandFilledTextInputautoCorrect={true}inLogsModal,SurveyModal, andSendFromFioRowsto preserve autocorrect for free-form text compositionAutocorrect Status by Callsite
Autocorrect now DISABLED (was enabled before this PR):
Autocorrect remains DISABLED (no change):
Autocorrect remains ENABLED (intentional):
Requirements
If you have made any visual changes to the GUI. Make sure you have: