Skip to content

Fix upper bound on non-strict while#941

Merged
strub merged 1 commit intomainfrom
fix-non-strict-variant-while
Mar 16, 2026
Merged

Fix upper bound on non-strict while#941
strub merged 1 commit intomainfrom
fix-non-strict-variant-while

Conversation

@oskgo
Copy link
Contributor

@oskgo oskgo commented Mar 16, 2026

Ensure that upper bound for variant in non-strict while cannot be written to during the loop.

Fixes #917

@strub strub self-assigned this Mar 16, 2026
@strub strub added the bug label Mar 16, 2026
@strub strub force-pushed the fix-non-strict-variant-while branch from 2710851 to 265b6aa Compare March 16, 2026 14:25
@strub strub enabled auto-merge (rebase) March 16, 2026 14:25
@strub strub merged commit 2107767 into main Mar 16, 2026
16 checks passed
@strub strub deleted the fix-non-strict-variant-while branch March 16, 2026 14:42
@oskgo
Copy link
Contributor Author

oskgo commented Mar 16, 2026

@strub I notice that you've changed the error messages. I wrote them the way I did (with a single string literal with a \n in the middle) on purpose. The version with two string literals doesn't print properly in my emacs, emitting just the first string.

@strub
Copy link
Member

strub commented Mar 16, 2026

@strub I notice that you've changed the error messages. I wrote them the way I did (with a single string literal with a \n in the middle) on purpose. The version with two string literals doesn't print properly in my emacs, emitting just the first string.

The carriage return should be avoided because you do not know the width of the output display (especially with the VSCode plugin coming in line).

I don't understand what the 2 string literals solution does not work. Will look at it now.

@strub
Copy link
Member

strub commented Mar 16, 2026

@oskgo Fixed in 7367ad0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

unsoundness in pHL while with non-strict variant

2 participants