Open
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the zarrita peer dependency to support version 0.6.0 alongside 0.5.0. Feedback was provided to update the devDependencies to include version 0.6.0, ensuring that the project's tests verify compatibility with the newly supported version.
| }, | ||
| "peerDependencies": { | ||
| "zarrita": "^0.5.0" | ||
| "zarrita": "^0.5.0 || ^0.6.0" |
There was a problem hiding this comment.
The devDependencies (line 58) should be updated to include ^0.6.0 (e.g., ^0.5.0 || ^0.6.0). Currently, local development and tests are pinned to version 0.5.x, which means compatibility with the newly supported version 0.6.0 is not being verified during development or in standard test runs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#6
Adds latest zarrita to peer deps and adds tests for both supported versions to CI.