Remove increased divergence damping for SE dycore + frontogenesis function bug fix for FV dycore#1455
Conversation
PeterHjortLauritzen
changed the title
cacraigucar
left a comment
cacraigucar
left a comment
There was a problem hiding this comment.
The original code base appears to be really old (cam6_4_089 according to the ChangeLog). Could you please merge it forward in case there are any merge conflicts?
| ! Topography correction | ||
| ux(i,k,j) = ux(i,k,j) / (aearth * (grid%cosp(j)+1.e-3_r8)) | ||
|
|
||
| ! Topography correction | ||
| ux(i,k,j) = ux(i,k,j) - dudp(i,k,j) * & | ||
| ( pmg(ip,k,j) - pmg(im,k,j) )/(2._r8 * grid%dl)/(aearth * (grid%cosp(j)+1.e-3_r8)) | ||
|
|
There was a problem hiding this comment.
Wondering if you can give a bit more detail on "topography correction" or remove lines 169 and 170 (the blank line and duplicated comment) so the comment applies to both lines.
There was a problem hiding this comment.
Horizontal temperature gradient for fronotogenesis function was originally computed over terrain-following coordinate. The correction terms are added so horizontal temperature gradient is on isobaric coordinate. This applies for all "correction" terms.
|
Closing this PR due to #1449 Will do a seperate PR for the FV frontogenisis function fix ... |
3 participants
Remove increased divergence damping in SE dycore: closes #1449
Fix bug in frontogenesis function for FV dycore: partially closes #1414
(science tested by ACOM; there will be namelist changes to re-tune QBO with the fixed frontogenesis function)
@fvitt @mbramberger @tilmes @chihchen24
Remove failing WACCM6 70 level CAM6 test with SE dycore: SMS_Ln9.ne30pg3_ne30pg3_mg17.FW2000climo.derecho_intel.cam-outfrq9s_rrtmgp
closes #1450