Merged
Conversation
bedroge
previously approved these changes
Sep 12, 2025
Collaborator
bedroge
left a comment
bedroge
left a comment
There was a problem hiding this comment.
Tested it locally and it worked, though we need to rerun the workflow for updating the json file too.
Collaborator
|
@laraPPr do you know why the CI is failing? |
Contributor
Could it be because the JSON files are not updated yet? Do we need to do this in 2 steps? |
bedroge
approved these changes
Sep 12, 2025
Collaborator
Author
|
No @bedroge found it but I have ran into this before. I think this was a change in one of the dependencies. The Tests kept failing months ago when I was testing it so than I had to add those spaces. This now seems to be resolved so now they can be removed again |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.