SAQ-2077: Insert subscripted dimnames into footerhtml attribute for improved visibility of table contents when printing #128
+174
−62
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mproved visibility of table contents when printing (#126) Refactors how QTable names and subscripting are handled, with a focus on improving footer HTML updates when tables are subscripted. The changes 1. Simplify the name attribute handling (name isn't changed) as the subscripting indices are not concatenated to the name attribute. 2. Updates the `footerhtml` attribute by inserting the `dimnames` that are used in the subscript, in the format (name 1, name2). E.g. `table[1:2, 2:3]` may have updated `footerhtml` attribute `A by B (rowname1, rowname2), (colname2, colname3)`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reimplements #126 but with two changes.
footerhtmlattribute isn't saved in the same location when a table is subscripted. That is, the table caption is not retained when a table is subscripted."subscripted.footerhtml". This footer is the same as the original footer but does the same transformation that was implemented in SAQ-2077: Insert subscripted dimnames into footerhtml attribute for improved visibility of table contents when printing #126