Skip to content

chore: consolidate security scanning tools#188

Merged
vredchenko merged 1 commit intomainfrom
chore/remove-detect-secrets-trufflehog-pip-audit
Apr 10, 2026
Merged

chore: consolidate security scanning tools#188
vredchenko merged 1 commit intomainfrom
chore/remove-detect-secrets-trufflehog-pip-audit

Conversation

@vredchenko
Copy link
Copy Markdown
Collaborator

Summary

  • Remove detect-secrets and trufflehog from pre-commit hooks, lefthook, and CI workflow (secret scanning consolidated to gitleaks)
  • Remove pip-audit scan script (scripts/pip-audit-scan-repos.sh) (vulnerability scanning consolidated to osv-scanner)
  • Delete .secrets.baseline (only used by detect-secrets)
  • Update documentation references (ADR, ARCHITECTURE.md, skill/agent docs) to reflect gitleaks as the single secret scanner

This reduces the security tool stack from 6 tools to 3 (gitleaks + osv-scanner + pre-commit-hooks), simplifying maintenance and aligning with the organisational preference for gitleaks.

Changes

File Change
.pre-commit-config.yaml Remove detect-secrets and trufflehog hook entries
.secrets.baseline Deleted
lefthook.yml Remove trufflehog from pre-push hooks
.github/workflows/leaked-secrets-scan.yml Remove detect-secrets and trufflehog jobs, keep gitleaks
scripts/pip-audit-scan-repos.sh Deleted (osv-scanner covers this)
ADR 0005 Status updated to "Superseded by gitleaks consolidation"
claude-code/ARCHITECTURE.md detect-secrets reference updated to gitleaks
claude-code/shared/skills/devops/SKILL.md detect-secrets reference updated to gitleaks
claude-code/smartem-decisions/agents/devops.md detect-secrets reference updated to gitleaks

Consolidate secret scanning to gitleaks, vulnerability scanning to osv-scanner.
@github-actions github-actions Bot added documentation Improvements or additions to project documentation devops CI/CD, deployment, infrastructure, or tooling work smartem-devtools:claude Claude Code configuration, skills, and prompts labels Apr 8, 2026
@vredchenko vredchenko merged commit f631678 into main Apr 10, 2026
7 checks passed
@vredchenko vredchenko deleted the chore/remove-detect-secrets-trufflehog-pip-audit branch April 10, 2026 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

devops CI/CD, deployment, infrastructure, or tooling work documentation Improvements or additions to project documentation smartem-devtools:claude Claude Code configuration, skills, and prompts

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant