Skip to content

move CONFIG_SERVER_URL environment variable name to a constant#2051

Merged
rtuck99 merged 1 commit into
mainfrom
CONFIG_SERVER_URL_env_var_constant
May 7, 2026
Merged

move CONFIG_SERVER_URL environment variable name to a constant#2051
rtuck99 merged 1 commit into
mainfrom
CONFIG_SERVER_URL_env_var_constant

Conversation

@rtuck99
Copy link
Copy Markdown
Contributor

@rtuck99 rtuck99 commented May 7, 2026

moves CONFIG_SERVER_URL into a constant as suggested in

Instructions to reviewer on how to test:

  1. Tests pass

Checks for reviewer

  • Would the PR title make sense to a scientist on a set of release notes
  • If a new device has been added does it follow the standards
  • If changing the API for a pre-existing device, ensure that any beamlines using this device have updated their Bluesky plans accordingly
  • Have the connection tests for the relevant beamline(s) been run via dodal connect ${BEAMLINE}

@rtuck99 rtuck99 marked this pull request as ready for review May 7, 2026 14:33
@rtuck99 rtuck99 requested a review from a team as a code owner May 7, 2026 14:33
@codecov
Copy link
Copy Markdown

codecov Bot commented May 7, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.11%. Comparing base (4ba9de1) to head (6f756e4).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2051   +/-   ##
=======================================
  Coverage   99.11%   99.11%           
=======================================
  Files         327      327           
  Lines       12810    12812    +2     
=======================================
+ Hits        12697    12699    +2     
  Misses        113      113           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rtuck99 rtuck99 merged commit 0649293 into main May 7, 2026
10 checks passed
@rtuck99 rtuck99 deleted the CONFIG_SERVER_URL_env_var_constant branch May 7, 2026 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants