Adds conversion between material depth and attenuation#2049
Open
Matt-Carre wants to merge 14 commits intomainfrom
Open
Adds conversion between material depth and attenuation#2049Matt-Carre wants to merge 14 commits intomainfrom
Matt-Carre wants to merge 14 commits intomainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2049 +/- ##
=======================================
Coverage 99.11% 99.12%
=======================================
Files 327 329 +2
Lines 12814 12842 +28
=======================================
+ Hits 12701 12729 +28
Misses 113 113 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
CoePaul
reviewed
May 5, 2026
CoePaul
reviewed
May 5, 2026
CoePaul
reviewed
May 5, 2026
CoePaul
reviewed
May 5, 2026
CoePaul
reviewed
May 5, 2026
CoePaul
requested changes
May 5, 2026
… how best to split functions - will be done next time
…n_depth_attenuation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2041
Adds tests and functions to convert between depth (measured in cm) and attenuation