Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2044 +/- ##
==========================================
+ Coverage 99.11% 99.27% +0.15%
==========================================
Files 327 327
Lines 12814 12595 -219
==========================================
- Hits 12701 12504 -197
+ Misses 113 91 -22 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
1d4a8d7 to
f4cc423
Compare
DominicOram
left a comment
There was a problem hiding this comment.
clear_devices is used by mx-bluesky so this will require some changes there too. I'm not sure how significant they will be @DiamondLightSource/developers-mx-daq?
| return decorator | ||
|
|
||
|
|
||
| def set_path_provider(provider: PathProvider): |
There was a problem hiding this comment.
Should: Do we still need this? And the get/clear? It was my understanding that BlueAPI now handles the path provider a different way?
There was a problem hiding this comment.
Hyperion is still using it because it sets its own path provider
There was a problem hiding this comment.
That's annoying. Can we have BlueAPI inject the path provider into the composite so that we can avoid having the globals around?
Requires matching changes to avoid breakage:
All beamlines are now using a device manager to mark the device factories so the previous decorator and supporting code is no longer required.