Skip to content

Adds basic unit conversions for attenuator in general_maths folder#2043

Open
Matt-Carre wants to merge 14 commits intomainfrom
2038_basic_conversions
Open

Adds basic unit conversions for attenuator in general_maths folder#2043
Matt-Carre wants to merge 14 commits intomainfrom
2038_basic_conversions

Conversation

@Matt-Carre
Copy link
Copy Markdown

Closes #2038

Begins to work on translating over the calculations behind the attenuator to be available in Dodal. Separates conversions and boundary checks into two different files. Also translates over unit tests.

@Matt-Carre Matt-Carre requested a review from a team as a code owner May 1, 2026 13:11
@codecov
Copy link
Copy Markdown

codecov Bot commented May 1, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.12%. Comparing base (0beeb31) to head (7618002).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2043   +/-   ##
=======================================
  Coverage   99.11%   99.12%           
=======================================
  Files         327      329    +2     
  Lines       12814    12842   +28     
=======================================
+ Hits        12701    12729   +28     
  Misses        113      113           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread src/dodal/common/general_maths/arithmetic_conversions.py Outdated
Comment thread src/dodal/common/general_maths/arithmetic_conversions.py Outdated
Comment thread src/dodal/common/general_maths/check_bounds.py Outdated
Comment thread src/dodal/common/general_maths/check_bounds.py Outdated
Comment thread src/dodal/common/general_maths/arithmetic_conversions.py Outdated
Comment thread src/dodal/common/general_maths/arithmetic_conversions.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add basic conversions ( used by- / useful for- attenuation ) to arithmetic module

4 participants