Fix electron analyser regions not accepting field names

[oliwenmandiamond]

Fixes #1994

Instructions to reviewer on how to test:

1. Check tests pass

Checks for reviewer

• Would the PR title make sense to a scientist on a set of release notes
• If a new device has been added does it follow the standards
• If changing the API for a pre-existing device, ensure that any beamlines using this device have updated their Bluesky plans accordingly
• Have the connection tests for the relevant beamline(s) been run via dodal connect ${BEAMLINE}

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.11%. Comparing base (553594d) to head (c324fc6).

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1995      +/-   ##
==========================================
- Coverage   99.11%   99.11%   -0.01%     
==========================================
  Files         327      327              
  Lines       12814    12810       -4     
==========================================
- Hits        12701    12697       -4     
  Misses        113      113              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[Villtord]

Tests pytest --no-cov tests/devices/electron_analyser/ pass, but at the end I get

================================================================ 155 passed in 2.35s =================================================================
Future exception was never retrieved
future: <Future finished exception=FailedStatus(<AsyncStatus, device: ew4000-driver-detector_mode, task: <coroutine object AsyncStatusBase.__init__.<locals>.wait_with_error_message at 0x7f48b64fa140>, errored: ValueError("<DetectorModeTestEnum.TEST_1: 'INVALID_DETECTOR_MODE'> is not a valid DetectorMode")>)>

[oliwenmandiamond]

pytest --no-cov tests/devices/electron_analyser/

are you sure it isn't something to do with your env? I can't replicate and is fine for me

$ pytest --no-cov tests/devices/electron_analyser/
============================================================================ test session starts ============================================================================
platform linux -- Python 3.11.14, pytest-9.0.2, pluggy-1.6.0 -- /cache/venv-for/scratch/bluesky_development/dodal/bin/python3
cachedir: .pytest_cache
Test order randomisation NOT enabled. Enable with --random-order or --random-order-bucket=<bucket_type>
metadata: {'Python': '3.11.14', 'Platform': 'Linux-4.18.0-553.105.1.el8_10.x86_64-x86_64-with-glibc2.39', 'Packages': {'pytest': '9.0.2', 'pluggy': '1.6.0'}, 'Plugins': {'json-report': '1.5.0', 'random-order': '1.2.0', 'timeout': '2.4.0', 'anyio': '4.12.1', 'asyncio': '1.3.0', 'cov': '7.0.0', 'metadata': '3.1.1'}}
rootdir: /workspaces/dodal
configfile: pyproject.toml
plugins: json-report-1.5.0, random-order-1.2.0, timeout-2.4.0, anyio-4.12.1, asyncio-1.3.0, cov-7.0.0, metadata-3.1.1
timeout: 1.0s
timeout method: signal
timeout func_only: False
asyncio: mode=Mode.AUTO, debug=False, asyncio_default_fixture_loop_scope=None, asyncio_default_test_loop_scope=function
collected 155 items                                                                                                                                                         

tests/devices/electron_analyser/base/test_base_controller.py::test_controller_prepare_sets_excitation_energy[ew4000] PASSED                                           [  0%]
tests/devices/electron_analyser/base/test_base_controller.py::test_controller_prepare_sets_excitation_energy[b07b_specs150] PASSED                                    [  1%]
tests/devices/electron_analyser/base/
...
tests/devices/electron_analyser/vgscienta/test_vgscienta_region.py::test_load_sequence_using_alias_field_names_has_expected_enabled_region_names PASSED               [ 98%]
tests/devices/electron_analyser/vgscienta/test_vgscienta_region.py::test_load_sequence_using_alias_field_names_has_expected_values PASSED                             [ 99%]
tests/devices/electron_analyser/vgscienta/test_vgscienta_region.py::test_region_loads_using_field_names_has_expected_values PASSED                                    [100%]

============================================================================ 155 passed in 3.90s ============================================================================
root ➜ /workspaces/dodal (Fix_electron_analyser_regions_not_accepting_field_names) 

[Villtord]

yes it was old container image, gone after rebuild.

[Villtord]

SO that is the core change if I get it right? the rest is renaming and also you added test case for alias/field names loading.