Hla 966 improve validation #48
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This likely needs further refinement, but it should catch most accidental errors. The issue with using a more restrictive regex is that it will not provide a clear description of any error.
Note that this does not ensure that the bash script will actually run successfully. There may be additional errors e.g. by using an unavailable function or tool.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #48 +/- ##
==========================================
- Coverage 76.69% 75.64% -1.06%
==========================================
Files 25 25
Lines 914 936 +22
==========================================
+ Hits 701 708 +7
- Misses 213 228 +15 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ptsOSL
reviewed
Jan 13, 2026
ptsOSL
approved these changes
Jan 14, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This mostly catches accidental errors.
A more restrictive regex for the URLs could be used, but then the errors are difficult to understand. If the final URL isn't valid, it should raise an error during validation as it attempts to build the Apptainer images.