-
Notifications
You must be signed in to change notification settings - Fork 6
Add always flag to add_on_update_callback
#311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
shihab-dls
wants to merge
5
commits into
main
Choose a base branch
from
306_callbacks_on_change
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GDYendell
reviewed
Jan 23, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #311 +/- ##
=======================================
Coverage 90.69% 90.69%
=======================================
Files 70 70
Lines 2535 2537 +2
=======================================
+ Hits 2299 2301 +2
Misses 236 236 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
always flag to add_on_update_callback
Contributor
Author
|
Tested with @dataclass
class BitGroupOnUpdate:
"""Bits are tied together in bit groups so that when one is set for capture,
they all are.
This callback sets all capture attributes in the group when one of them is set.
"""
capture_attribute: AttrRW[enum.Enum]
bit_attributes: list[AttrRW[bool]]
async def __call__(self, value: Any):
if isinstance(value, enum.Enum):
bool_value = bool(self.capture_attribute.datatype.index_of(value)) # type: ignore
enum_value = value
else:
bool_value = value
assert isinstance(self.capture_attribute.datatype, Enum)
enum_value = self.capture_attribute.datatype.members[int(value)]
await asyncio.gather(
*(bit_attr.update(bool_value) for bit_attr in self.bit_attributes),
self.capture_attribute.update(enum_value),
)removing the need for: async def _set_attr_if_not_already_value(attribute: AttrRW[DType_T], value: DType_T):
if attribute.get() != value:
await attribute.update(value)So, this PR will be updated to close #133, as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #306 and closes #133
Adds an always flag to
add_on_update_callback, and checks this flag when deciding what callback to call inupdate.